Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/extensions/extension_tab_util_athena.cc

Issue 676813002: athena: Replace NOTREACHED with NOTIMPLEMENTED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_tab_util.h" 5 #include "chrome/browser/extensions/extension_tab_util.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 9 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents, 113 bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents,
114 TabStripModel** tab_strip_model, 114 TabStripModel** tab_strip_model,
115 int* tab_index) { 115 int* tab_index) {
116 NOTIMPLEMENTED(); 116 NOTIMPLEMENTED();
117 return false; 117 return false;
118 } 118 }
119 119
120 bool ExtensionTabUtil::GetDefaultTab(Browser* browser, 120 bool ExtensionTabUtil::GetDefaultTab(Browser* browser,
121 WebContents** contents, 121 WebContents** contents,
122 int* tab_id) { 122 int* tab_id) {
123 NOTREACHED(); 123 NOTIMPLEMENTED();
124 return false; 124 return false;
125 } 125 }
126 126
127 bool ExtensionTabUtil::GetTabById(int tab_id, 127 bool ExtensionTabUtil::GetTabById(int tab_id,
128 content::BrowserContext* browser_context, 128 content::BrowserContext* browser_context,
129 bool include_incognito, 129 bool include_incognito,
130 Browser** browser, 130 Browser** browser,
131 TabStripModel** tab_strip, 131 TabStripModel** tab_strip,
132 WebContents** contents, 132 WebContents** contents,
133 int* tab_index) { 133 int* tab_index) {
134 NOTREACHED(); return false; 134 NOTIMPLEMENTED();
135 return false;
135 } 136 }
136 137
137 GURL ExtensionTabUtil::ResolvePossiblyRelativeURL(const std::string& url_string, 138 GURL ExtensionTabUtil::ResolvePossiblyRelativeURL(const std::string& url_string,
138 const Extension* extension) { 139 const Extension* extension) {
139 // TODO(oshima): Move this to common impl. 140 // TODO(oshima): Move this to common impl.
140 return GURL(url_string); 141 return GURL(url_string);
141 } 142 }
142 143
143 bool ExtensionTabUtil::IsCrashURL(const GURL& url) { 144 bool ExtensionTabUtil::IsCrashURL(const GURL& url) {
144 // TODO(oshima): Move this to common impl. 145 // TODO(oshima): Move this to common impl.
(...skipping 20 matching lines...) Expand all
165 NOTIMPLEMENTED(); 166 NOTIMPLEMENTED();
166 return NULL; 167 return NULL;
167 } 168 }
168 169
169 void ExtensionTabUtil::OpenOptionsPage(const Extension* extension, 170 void ExtensionTabUtil::OpenOptionsPage(const Extension* extension,
170 Browser* browser) { 171 Browser* browser) {
171 // NOTIMPLEMENTED(); 172 // NOTIMPLEMENTED();
172 } 173 }
173 174
174 } // namespace extensions 175 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698