Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: chrome/browser/extensions/extension_tab_util_athena.cc

Issue 676813002: athena: Replace NOTREACHED with NOTIMPLEMENTED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tab_util_athena.cc
diff --git a/chrome/browser/extensions/extension_tab_util_athena.cc b/chrome/browser/extensions/extension_tab_util_athena.cc
index cdfe7a1e0cea4db76774ae3898ed58a48d354856..47b4ef586c56d220824d94738cacaff22cb24e88 100644
--- a/chrome/browser/extensions/extension_tab_util_athena.cc
+++ b/chrome/browser/extensions/extension_tab_util_athena.cc
@@ -120,7 +120,7 @@ bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents,
bool ExtensionTabUtil::GetDefaultTab(Browser* browser,
WebContents** contents,
int* tab_id) {
- NOTREACHED();
+ NOTIMPLEMENTED();
return false;
}
@@ -131,7 +131,8 @@ bool ExtensionTabUtil::GetTabById(int tab_id,
TabStripModel** tab_strip,
WebContents** contents,
int* tab_index) {
- NOTREACHED(); return false;
+ NOTIMPLEMENTED();
+ return false;
}
GURL ExtensionTabUtil::ResolvePossiblyRelativeURL(const std::string& url_string,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698