Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 676353002: [turbofan] Merge GenericNode with Node. (Closed)

Created:
6 years, 1 month ago by Jarin
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Merge GenericNode with Node. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24915

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix Win64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -618 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/generic-algorithm.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/generic-algorithm-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/generic-graph.h View 1 chunk +3 lines, -4 lines 0 comments Download
D src/compiler/generic-node.h View 1 1 chunk +0 lines, -279 lines 0 comments Download
D src/compiler/generic-node-inl.h View 1 1 chunk +0 lines, -267 lines 0 comments Download
M src/compiler/graph.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/graph-builder.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/node.h View 1 2 chunks +253 lines, -18 lines 0 comments Download
M src/compiler/node.cc View 1 2 3 chunks +226 lines, -2 lines 0 comments Download
M src/compiler/node-cache.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/node-matchers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/phi-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/value-numbering-reducer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Michael Starzinger
LGTM.
6 years, 1 month ago (2014-10-27 11:50:08 UTC) #2
Jarin
6 years, 1 month ago (2014-10-27 20:37:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 24915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698