Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 675793002: Disabled AndroidWebView.testScrollToBottomAtPageScaleX0dot5 test. (Closed)

Created:
6 years, 2 months ago by bokan
Modified:
5 years, 11 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disabled AndroidWebView.testScrollToBottomAtPageScaleX0dot5 test. This test doesn't work under virtual viewport pinch-to-zoom since it assumes window.scrollTo() moves the virtual viewport. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
bokan
This one test is busted by turning on virtual viewport. If it's ok to disable ...
6 years, 2 months ago (2014-10-23 18:14:18 UTC) #2
aelias_OOO_until_Jul13
6 years, 2 months ago (2014-10-23 18:32:15 UTC) #4
[+mkosiba] who's the owner of WebView scroll/pinch paths.

Marcin, for some context, we're planning to finally turn on the new pinch model
described in
https://docs.google.com/a/chromium.org/document/d/1KewSqexq4Pd99RUFB-yVoUIJoc...
for M40.  The "outer viewport" is the only one visible to JS in this new model
and it's always sized to the width of the document (and the height of it is the
aspect ratio of the screen times that width).  For that reason it's not possible
for JS to scroll a pinched viewport to the absolute bottom.  This is by design
so that the effects of pinch are entirely hidden from sites not designed with it
in mind.

For the CC <-> Java delegate API, we can maintain the same behavior as before
though, by combining the inner and outer scroll offsets in the value given to
Java.

For this test, it seems like it should probably be changed to use input events
rather than the JS call.

Powered by Google App Engine
This is Rietveld 408576698