Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java

Issue 675793002: Disabled AndroidWebView.testScrollToBottomAtPageScaleX0dot5 test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
index 5f8b8055297f56d19f49e2459edd0c283460b643..7e0806331f365ecc386532a2347b23c12ee8ea93 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
@@ -538,7 +538,13 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
assertScrollOnMainSync(testContainerView, 0, 0);
}
- @SmallTest
+ /**
+ * Temporarily disabled.
+ * Disabled for pinch virtual viewport mode. In virtual viewport mode the window.scrollTo()
+ * method used to scroll the viewport applies scroll to the outer viewport, which is unchanged
+ * by the page scale. This test should be rewritten to account for this.
+ */
+ @DisabledTest
@Feature({"AndroidWebView"})
public void testScrollToBottomAtPageScaleX0dot5() throws Throwable {
// The idea behind this test is to check that scrolling to the bottom on ther renderer side
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698