Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 675753002: [DevTools] Drop "ui" module from toolbox. (Closed)

Created:
6 years, 2 months ago by dgozman
Modified:
6 years, 2 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Drop "ui" module from toolbox. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184355

Patch Set 1 #

Patch Set 2 : less moving #

Patch Set 3 : rootview bug fix #

Total comments: 2

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -954 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/bindings/FileUtils.js View 1 chunk +1 line, -3 lines 0 comments Download
M Source/devtools/front_end/bindings/Linkifier.js View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/bindings/ResourceUtils.js View 5 chunks +4 lines, -8 lines 0 comments Download
A + Source/devtools/front_end/host/DOMExtension.js View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M Source/devtools/front_end/host/ToolboxHost.js View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/devtools/front_end/host/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 2 3 3 chunks +16 lines, -5 lines 0 comments Download
M Source/devtools/front_end/main/App.js View 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/main/ScreencastApp.js View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/SimpleApp.js View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/toolbox.json View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 1 2 3 1 chunk +2 lines, -9 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/module.json View 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/ui/DOMExtension.js View 1 2 3 1 chunk +0 lines, -871 lines 0 comments Download
M Source/devtools/front_end/ui/Popover.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/RootView.js View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/module.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please. The main change is moving DOMExtension.js to the host module.
6 years, 2 months ago (2014-10-23 13:50:54 UTC) #2
pfeldman
lgtm. https://codereview.chromium.org/675753002/diff/40001/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (right): https://codereview.chromium.org/675753002/diff/40001/Source/devtools/front_end/main/AdvancedApp.js#newcode101 Source/devtools/front_end/main/AdvancedApp.js:101: WebInspector.installPortStyles(toolboxDocument); I think I removed this one.
6 years, 2 months ago (2014-10-23 14:49:08 UTC) #3
dgozman
https://codereview.chromium.org/675753002/diff/40001/Source/devtools/front_end/main/AdvancedApp.js File Source/devtools/front_end/main/AdvancedApp.js (right): https://codereview.chromium.org/675753002/diff/40001/Source/devtools/front_end/main/AdvancedApp.js#newcode101 Source/devtools/front_end/main/AdvancedApp.js:101: WebInspector.installPortStyles(toolboxDocument); On 2014/10/23 14:49:08, pfeldman wrote: > I think ...
6 years, 2 months ago (2014-10-24 11:41:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675753002/60001
6 years, 2 months ago (2014-10-24 11:41:23 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 13:03:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 184355

Powered by Google App Engine
This is Rietveld 408576698