Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: Source/devtools/front_end/bindings/Linkifier.js

Issue 675753002: [DevTools] Drop "ui" module from toolbox. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/bindings/Linkifier.js
diff --git a/Source/devtools/front_end/bindings/Linkifier.js b/Source/devtools/front_end/bindings/Linkifier.js
index fd29a7e7695942284f74d3b22dc765732371a476..70c81c62a1be639177309cc4c75683b4b7f6baea 100644
--- a/Source/devtools/front_end/bindings/Linkifier.js
+++ b/Source/devtools/front_end/bindings/Linkifier.js
@@ -84,12 +84,10 @@ WebInspector.Linkifier.handleLink = function(url, lineNumber)
* @param {string=} title
* @param {string=} classes
* @return {!Element}
- * // FIXME: remove this suppression (crbug.com/425498).
- * @suppressGlobalPropertiesCheck
*/
WebInspector.Linkifier.linkifyUsingRevealer = function(revealable, text, fallbackHref, fallbackLineNumber, title, classes)
{
- var a = document.createElement("a");
+ var a = createElement("a");
a.className = (classes || "") + " webkit-html-resource-link";
a.textContent = text.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayedURLs);
a.title = title || text;
@@ -230,12 +228,10 @@ WebInspector.Linkifier.prototype = {
/**
* @param {string=} classes
* @return {!Element}
- * // FIXME: remove this suppression (crbug.com/425498).
- * @suppressGlobalPropertiesCheck
*/
_createAnchor: function(classes)
{
- var anchor = document.createElement("a");
+ var anchor = createElement("a");
anchor.className = (classes || "") + " webkit-html-resource-link";
/**
« no previous file with comments | « Source/devtools/front_end/bindings/FileUtils.js ('k') | Source/devtools/front_end/bindings/ResourceUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698