Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: Source/devtools/front_end/bindings/ResourceUtils.js

Issue 675753002: [DevTools] Drop "ui" module from toolbox. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/bindings/Linkifier.js ('k') | Source/devtools/front_end/host/DOMExtension.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/bindings/ResourceUtils.js
diff --git a/Source/devtools/front_end/bindings/ResourceUtils.js b/Source/devtools/front_end/bindings/ResourceUtils.js
index e35eabc854c8d2318166c3ac1e2ab326a6bec390..70f84e3eaa40caae4b8f44f9303ac5040a5f36c8 100644
--- a/Source/devtools/front_end/bindings/ResourceUtils.js
+++ b/Source/devtools/front_end/bindings/ResourceUtils.js
@@ -94,12 +94,10 @@ WebInspector.displayNameForURL = function(url)
* @param {string} string
* @param {function(string,string,number=,number=):!Node} linkifier
* @return {!DocumentFragment}
- * // FIXME: remove this suppression (crbug.com/425498).
- * @suppressGlobalPropertiesCheck
*/
WebInspector.linkifyStringAsFragmentWithCustomLinkifier = function(string, linkifier)
{
- var container = document.createDocumentFragment();
+ var container = createDocumentFragment();
var linkStringRegEx = /(?:[a-zA-Z][a-zA-Z0-9+.-]{2,}:\/\/|data:|www\.)[\w$\-_+*'=\|\/\\(){}[\]^%@&#~,:;.!?]{2,}[\w$\-_+*=\|\/\\({^%@&#~]/;
var lineColumnRegEx = /:(\d+)(:(\d+))?$/;
@@ -111,7 +109,7 @@ WebInspector.linkifyStringAsFragmentWithCustomLinkifier = function(string, linki
linkString = linkString[0];
var linkIndex = string.indexOf(linkString);
var nonLink = string.substring(0, linkIndex);
- container.appendChild(document.createTextNode(nonLink));
+ container.appendChild(createTextNode(nonLink));
var title = linkString;
var realURL = (linkString.startsWith("www.") ? "http://" + linkString : linkString);
@@ -136,7 +134,7 @@ WebInspector.linkifyStringAsFragmentWithCustomLinkifier = function(string, linki
}
if (string)
- container.appendChild(document.createTextNode(string));
+ container.appendChild(createTextNode(string));
return container;
}
@@ -148,8 +146,6 @@ WebInspector.linkifyStringAsFragmentWithCustomLinkifier = function(string, linki
* @param {boolean=} isExternal
* @param {string=} tooltipText
* @return {!Element}
- * // FIXME: remove this suppression (crbug.com/425498).
- * @suppressGlobalPropertiesCheck
*/
WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, tooltipText)
{
@@ -158,7 +154,7 @@ WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, too
classes = (classes ? classes + " " : "");
classes += isExternal ? "webkit-html-external-link" : "webkit-html-resource-link";
- var a = document.createElement("a");
+ var a = createElement("a");
var href = sanitizeHref(url);
if (href !== null)
a.href = href;
« no previous file with comments | « Source/devtools/front_end/bindings/Linkifier.js ('k') | Source/devtools/front_end/host/DOMExtension.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698