Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 675473005: Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
vkuzkokov, caseq, dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (patchset #6 id:130001 of https://codereview.chromium.org/635733003/) Reason for revert: Broke compile, e.g. obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc:951:7: error: no viable conversion from 'std::string' (aka 'basic_string<char>') to 'const std::string *' (aka 'const basic_string<char> *') in_categories, ^~~~~~~~~~~~~ ../../content/browser/devtools/protocol/tracing_handler.h:40:26: note: passing argument to parameter 'categories' here const std::string* categories, ^ 1 error generated. ninja: build stopped: subcommand failed. Original issue's description: > [DevTools] Migrate DevToolsTracingHandler to generated handler. > > This patch also adds SendRawMessage, which is used for performance > in tracing handler. > > BUG=405566 > > Committed: https://crrev.com/f7762cb9261c8e2e15f2cf2b36f5408c75d72bdd > Cr-Commit-Position: refs/heads/master@{#300711} TBR=caseq@chromium.org,vkuzkokov@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=405566 Committed: https://crrev.com/27be78b94c43bb98d5b1cbd2cc1a4816872596ad Cr-Commit-Position: refs/heads/master@{#300726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -274 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 5 chunks +12 lines, -22 lines 0 comments Download
M content/browser/devtools/devtools_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
A content/browser/devtools/devtools_tracing_handler.h View 1 chunk +72 lines, -0 lines 0 comments Download
A content/browser/devtools/devtools_tracing_handler.cc View 1 chunk +241 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_client.h View 3 chunks +9 lines, -8 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_client.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 3 chunks +8 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.h View 3 chunks +7 lines, -34 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 3 chunks +11 lines, -175 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 3 chunks +7 lines, -10 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
Created Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler.
6 years, 2 months ago (2014-10-22 19:14:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675473005/1
6 years, 2 months ago (2014-10-22 19:17:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 19:20:17 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:20:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27be78b94c43bb98d5b1cbd2cc1a4816872596ad
Cr-Commit-Position: refs/heads/master@{#300726}

Powered by Google App Engine
This is Rietveld 408576698