Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: content/browser/devtools/protocol/tracing_handler.h

Issue 675473005: Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/tracing_handler.h
diff --git a/content/browser/devtools/protocol/tracing_handler.h b/content/browser/devtools/protocol/tracing_handler.h
index b20e5854a3b4555d1c621b7f2fc192817c3a5aad..c629188b73d77df6eda9035f09b0265707cb320c 100644
--- a/content/browser/devtools/protocol/tracing_handler.h
+++ b/content/browser/devtools/protocol/tracing_handler.h
@@ -5,18 +5,7 @@
#ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_
#define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_
-#include <set>
-#include <string>
-
-#include "base/debug/trace_event.h"
-#include "base/memory/weak_ptr.h"
#include "content/browser/devtools/protocol/devtools_protocol_handler_impl.h"
-#include "content/public/browser/tracing_controller.h"
-
-namespace base {
-class RefCountedString;
-class Timer;
-}
namespace content {
namespace devtools {
@@ -26,16 +15,16 @@
public:
typedef DevToolsProtocolClient::Response Response;
- enum Target { Browser, Renderer };
- explicit TracingHandler(Target target);
+ TracingHandler();
virtual ~TracingHandler();
void SetClient(scoped_ptr<Client> client);
- void Detached();
- void OnTraceDataCollected(const std::string& trace_fragment);
- void OnTraceComplete();
-
+ scoped_refptr<DevToolsProtocol::Response> Start(
+ const std::string& categories,
+ const std::string& options,
+ const double* buffer_usage_reporting_interval,
+ scoped_refptr<DevToolsProtocol::Command> command);
scoped_refptr<DevToolsProtocol::Response> Start(
const std::string* categories,
const std::string* options,
@@ -44,28 +33,12 @@
scoped_refptr<DevToolsProtocol::Response> End(
scoped_refptr<DevToolsProtocol::Command> command);
+
scoped_refptr<DevToolsProtocol::Response> GetCategories(
scoped_refptr<DevToolsProtocol::Command> command);
private:
- void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command);
- void OnBufferUsage(float usage);
-
- void OnCategoriesReceived(scoped_refptr<DevToolsProtocol::Command> command,
- const std::set<std::string>& category_set);
-
- base::debug::TraceOptions TraceOptionsFromString(const std::string* options);
-
- void SetupTimer(double usage_reporting_interval);
-
- void DisableRecording(bool abort);
-
- scoped_ptr<base::Timer> buffer_usage_poll_timer_;
- Target target_;
- bool is_recording_;
-
scoped_ptr<Client> client_;
- base::WeakPtrFactory<TracingHandler> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(TracingHandler);
};

Powered by Google App Engine
This is Rietveld 408576698