content/browser/devtools/protocol/devtools_protocol_handler_generator.py - Issue 675473005: Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Issue 675473005: Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_client.cc ('k') | content/browser/devtools/protocol/tracing_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

diff --git a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

index dd165faec5f34eb139e1db9ef62166ed3f250f8d..6aa39f8dc04113c55390558c2f23b2016366066f 100755

--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

@@ -120,7 +120,8 @@

namespace ${domain} {

class Client : public DevToolsProtocolClient {

public:

- Client(const RawMessageCallback& raw_message_callback);

+ Client(const EventCallback& event_callback,

+ const ResponseCallback& response_callback);

virtual ~Client();

${methods}\

@@ -245,7 +246,9 @@

tmpl_init_client = string.Template("""\

${domain}_handler_->SetClient(make_scoped_ptr(

new devtools::${domain}::Client(

- base::Bind(&DevToolsProtocolHandlerImpl::SendRawMessage,

+ base::Bind(&DevToolsProtocolHandlerImpl::SendNotification,

+ base::Unretained(this)),

+ base::Bind(&DevToolsProtocolHandlerImpl::SendAsyncResponse,

base::Unretained(this)))));

""")

@@ -355,8 +358,9 @@

tmpl_client_impl = string.Template("""\

namespace ${domain} {

-Client::Client(const RawMessageCallback& raw_message_callback)

- : DevToolsProtocolClient(raw_message_callback) {

+Client::Client(const EventCallback& event_callback,

+ const ResponseCallback& response_callback)

+ : DevToolsProtocolClient(event_callback, response_callback) {

}

Client::~Client() {