Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 675343003: Prune a bunch of webkitpy. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Prune a bunch of webkitpy. Remove a bunch of unused bits. Some of these bits we might want to add back (e.g. the python style checker), but we'd want it as part of the mojo style checker. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c5865b2630d13fee4dc1d7fe3bdb83ff0bf15715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21985 lines) Patch
D sky/tools/webkitpy/common/checksvnconfigfile.py View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/tools/webkitpy/style/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/webkitpy/style/checker.py View 1 chunk +0 lines, -743 lines 0 comments Download
D sky/tools/webkitpy/style/checker_unittest.py View 1 chunk +0 lines, -818 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/webkitpy/style/checkers/common.py View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/common_unittest.py View 1 chunk +0 lines, -121 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/cpp.py View 1 chunk +0 lines, -4082 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/cpp_unittest.py View 1 chunk +0 lines, -5210 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/jsonchecker.py View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/jsonchecker_unittest.py View 1 chunk +0 lines, -111 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/png.py View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/png_unittest.py View 1 chunk +0 lines, -132 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/python.py View 1 chunk +0 lines, -122 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/python_unittest.py View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/python_unittest_input.py View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/test_expectations.py View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/test_expectations_unittest.py View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/text.py View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/text_unittest.py View 1 chunk +0 lines, -89 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/xcodeproj.py View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/xcodeproj_unittest.py View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/xml.py View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/tools/webkitpy/style/checkers/xml_unittest.py View 1 chunk +0 lines, -86 lines 0 comments Download
D sky/tools/webkitpy/style/error_handlers.py View 1 chunk +0 lines, -164 lines 0 comments Download
D sky/tools/webkitpy/style/error_handlers_unittest.py View 1 chunk +0 lines, -195 lines 0 comments Download
D sky/tools/webkitpy/style/filereader.py View 1 chunk +0 lines, -154 lines 0 comments Download
D sky/tools/webkitpy/style/filereader_unittest.py View 1 chunk +0 lines, -155 lines 0 comments Download
D sky/tools/webkitpy/style/filter.py View 1 chunk +0 lines, -278 lines 0 comments Download
D sky/tools/webkitpy/style/filter_unittest.py View 1 chunk +0 lines, -256 lines 0 comments Download
D sky/tools/webkitpy/style/main.py View 1 chunk +0 lines, -162 lines 0 comments Download
D sky/tools/webkitpy/style/main_unittest.py View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/tools/webkitpy/style/optparser.py View 1 chunk +0 lines, -457 lines 0 comments Download
D sky/tools/webkitpy/style/optparser_unittest.py View 1 chunk +0 lines, -258 lines 0 comments Download
D sky/tools/webkitpy/style/patchreader.py View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/tools/webkitpy/style/patchreader_unittest.py View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/irc/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/webkitpy/thirdparty/irc/ircbot.py View 1 chunk +0 lines, -438 lines 0 comments Download
D sky/tools/webkitpy/thirdparty/irc/irclib.py View 1 chunk +0 lines, -1560 lines 0 comments Download
D sky/tools/webkitpy/tool/bot/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/webkitpy/tool/bot/commitannouncer.py View 1 chunk +0 lines, -201 lines 0 comments Download
D sky/tools/webkitpy/tool/bot/commitannouncer_unittest.py View 1 chunk +0 lines, -204 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/adduserstogroups.py View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/data/summary.html View 1 chunk +0 lines, -455 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/findusers.py View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/flakytests.py View 1 chunk +0 lines, -135 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/flakytests_unittest.py View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/rebaselineserver.py View 1 chunk +0 lines, -99 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/webkitpy/tool/servers/data/rebaselineserver/index.html View 1 chunk +0 lines, -182 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/data/rebaselineserver/loupe.js View 1 chunk +0 lines, -144 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/data/rebaselineserver/main.css View 1 chunk +0 lines, -313 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/data/rebaselineserver/main.js View 1 chunk +0 lines, -577 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/data/rebaselineserver/queue.js View 1 chunk +0 lines, -186 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/data/rebaselineserver/util.js View 1 chunk +0 lines, -104 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/rebaselineserver.py View 1 chunk +0 lines, -288 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/rebaselineserver_unittest.py View 1 chunk +0 lines, -313 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/reflectionhandler.py View 1 chunk +0 lines, -152 lines 0 comments Download
D sky/tools/webkitpy/tool/servers/reflectionhandler_unittest.py View 1 chunk +0 lines, -99 lines 0 comments Download
D sky/tools/webkitpy/w3c/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/webkitpy/w3c/test_converter.py View 1 chunk +0 lines, -197 lines 0 comments Download
D sky/tools/webkitpy/w3c/test_converter_unittest.py View 1 chunk +0 lines, -387 lines 0 comments Download
D sky/tools/webkitpy/w3c/test_importer.py View 1 chunk +0 lines, -460 lines 0 comments Download
D sky/tools/webkitpy/w3c/test_importer_unittest.py View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/tools/webkitpy/w3c/test_parser.py View 1 chunk +0 lines, -162 lines 0 comments Download
D sky/tools/webkitpy/w3c/test_parser_unittest.py View 1 chunk +0 lines, -215 lines 0 comments Download
D sky/tools/webkitpy/webgl/__init__.py View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tools/webkitpy/webgl/update_webgl_conformance_tests.py View 1 chunk +0 lines, -157 lines 0 comments Download
D sky/tools/webkitpy/webgl/update_webgl_conformance_tests_unittest.py View 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
There's still more to delete. This is just a start.
6 years, 1 month ago (2014-10-26 06:27:49 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-26 15:29:56 UTC) #3
ojan
6 years, 1 month ago (2014-10-26 17:36:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c5865b2630d13fee4dc1d7fe3bdb83ff0bf15715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698