Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: sky/tools/webkitpy/style/checkers/common.py

Issue 675343003: Prune a bunch of webkitpy. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/webkitpy/style/checkers/__init__.py ('k') | sky/tools/webkitpy/style/checkers/common_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/style/checkers/common.py
diff --git a/sky/tools/webkitpy/style/checkers/common.py b/sky/tools/webkitpy/style/checkers/common.py
deleted file mode 100644
index 76aa956b8a749ced0565e420da57429a9a34184a..0000000000000000000000000000000000000000
--- a/sky/tools/webkitpy/style/checkers/common.py
+++ /dev/null
@@ -1,74 +0,0 @@
-# Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-"""Supports style checking not specific to any one file type."""
-
-
-# FIXME: Test this list in the same way that the list of CppChecker
-# categories is tested, for example by checking that all of its
-# elements appear in the unit tests. This should probably be done
-# after moving the relevant cpp_unittest.ErrorCollector code
-# into a shared location and refactoring appropriately.
-categories = set([
- "whitespace/carriage_return",
- "whitespace/tab"])
-
-
-class CarriageReturnChecker(object):
-
- """Supports checking for and handling carriage returns."""
-
- def __init__(self, handle_style_error):
- self._handle_style_error = handle_style_error
-
- def check(self, lines):
- """Check for and strip trailing carriage returns from lines."""
- for line_number in range(len(lines)):
- if not lines[line_number].endswith("\r"):
- continue
-
- self._handle_style_error(line_number + 1, # Correct for offset.
- "whitespace/carriage_return",
- 1,
- "One or more unexpected \\r (^M) found; "
- "better to use only a \\n")
-
- lines[line_number] = lines[line_number].rstrip("\r")
-
- return lines
-
-
-class TabChecker(object):
-
- """Supports checking for and handling tabs."""
-
- def __init__(self, file_path, handle_style_error):
- self.file_path = file_path
- self.handle_style_error = handle_style_error
-
- def check(self, lines):
- # FIXME: share with cpp_style.
- for line_number, line in enumerate(lines):
- if "\t" in line:
- self.handle_style_error(line_number + 1,
- "whitespace/tab", 5,
- "Line contains tab character.")
« no previous file with comments | « sky/tools/webkitpy/style/checkers/__init__.py ('k') | sky/tools/webkitpy/style/checkers/common_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698