Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: sky/tools/webkitpy/style/checkers/png.py

Issue 675343003: Prune a bunch of webkitpy. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tools/webkitpy/style/checkers/png.py
diff --git a/sky/tools/webkitpy/style/checkers/png.py b/sky/tools/webkitpy/style/checkers/png.py
deleted file mode 100644
index 430d6f0a0e16f19d15cf0163290e1211a6c182b1..0000000000000000000000000000000000000000
--- a/sky/tools/webkitpy/style/checkers/png.py
+++ /dev/null
@@ -1,75 +0,0 @@
-# Copyright (C) 2012 Balazs Ankes (bank@inf.u-szeged.hu) University of Szeged
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-
-"""Supports checking WebKit style in png files."""
-
-import os
-import re
-
-from webkitpy.common import checksvnconfigfile
-from webkitpy.common import read_checksum_from_png
-from webkitpy.common.system.systemhost import SystemHost
-from webkitpy.common.checkout.scm.detection import SCMDetector
-
-class PNGChecker(object):
- """Check svn:mime-type for checking style"""
-
- categories = set(['image/png'])
-
- def __init__(self, file_path, handle_style_error, scm=None, host=None):
- self._file_path = file_path
- self._handle_style_error = handle_style_error
- self._host = host or SystemHost()
- self._fs = self._host.filesystem
- self._detector = scm or SCMDetector(self._fs, self._host.executive).detect_scm_system(self._fs.getcwd())
-
- def check(self, inline=None):
- errorstr = ""
- config_file_path = ""
- detection = self._detector.display_name()
-
- if self._fs.exists(self._file_path) and self._file_path.endswith("-expected.png"):
- with self._fs.open_binary_file_for_reading(self._file_path) as filehandle:
- if not read_checksum_from_png.read_checksum(filehandle):
- self._handle_style_error(0, 'image/png', 5, "Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum.")
-
- if detection == "git":
- (file_missing, autoprop_missing, png_missing) = checksvnconfigfile.check(self._host, self._fs)
- config_file_path = checksvnconfigfile.config_file_path(self._host, self._fs)
-
- if file_missing:
- self._handle_style_error(0, 'image/png', 5, "There is no SVN config file. (%s)" % config_file_path)
- elif autoprop_missing and png_missing:
- self._handle_style_error(0, 'image/png', 5, checksvnconfigfile.errorstr_autoprop(config_file_path) + checksvnconfigfile.errorstr_png(config_file_path))
- elif autoprop_missing:
- self._handle_style_error(0, 'image/png', 5, checksvnconfigfile.errorstr_autoprop(config_file_path))
- elif png_missing:
- self._handle_style_error(0, 'image/png', 5, checksvnconfigfile.errorstr_png(config_file_path))
-
- elif detection == "svn":
- prop_get = self._detector.propget("svn:mime-type", self._file_path)
- if prop_get != "image/png":
- errorstr = "Set the svn:mime-type property (svn propset svn:mime-type image/png %s)." % self._file_path
- self._handle_style_error(0, 'image/png', 5, errorstr)
-
« no previous file with comments | « sky/tools/webkitpy/style/checkers/jsonchecker_unittest.py ('k') | sky/tools/webkitpy/style/checkers/png_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698