Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 675173003: Move <svg:image> buffered-rendering management to SVGImagePainter (Closed)

Created:
6 years, 1 month ago by fs
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Move <svg:image> buffered-rendering management to SVGImagePainter There are no strong dependencies on SVGRenderingContext or other surroundings, so the move is reasonably straight-forward. While moving, modify the flow of the bufferForeground function a bit. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -55 lines) Patch
M Source/core/paint/SVGImagePainter.h View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/paint/SVGImagePainter.cpp View 2 chunks +46 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 2 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fs
6 years, 1 month ago (2014-10-28 20:12:34 UTC) #3
Stephen Chennney
lgtm
6 years, 1 month ago (2014-10-28 20:22:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675173003/20001
6 years, 1 month ago (2014-10-28 20:23:00 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 20:33:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as 184542

Powered by Google App Engine
This is Rietveld 408576698