Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 674703002: Linux: Dynamically load libudev. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scoped_udev
Project:
chromium
Visibility:
Public.

Description

Linux: Dynamically load libudev. Funnel all libudev access through a wrapper for the udev library loader. BUG=415212 Committed: https://crrev.com/ee816c278f12488490cb2e01fda46e4abab45af7 Cr-Commit-Position: refs/heads/master@{#305348}

Patch Set 1 : WIP #

Patch Set 2 : rebase #

Patch Set 3 : combine gn/gyp function lists #

Patch Set 4 : fix up all the things #

Patch Set 5 : rebase #

Patch Set 6 : fix ozone #

Patch Set 7 : pass checklicenses #

Patch Set 8 : rebase, components/usb_service is gone #

Patch Set 9 : Update Linux installer #

Patch Set 10 : rebase to head, which includes third_party/libudev already #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1388 lines, -567 lines) Patch
M build/config/linux/BUILD.gn View 1 2 6 chunks +37 lines, -35 lines 0 comments Download
M build/linux/system.gyp View 1 2 3 4 5 5 chunks +125 lines, -38 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc View 4 chunks +22 lines, -19 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/common/symlinks.include View 1 2 3 4 5 6 7 8 1 chunk +1 line, -23 lines 0 comments Download
M chrome/installer/linux/debian/build.sh View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32 View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64 View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/debian/postinst View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/build.sh View 1 2 3 4 5 6 7 8 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/linux/rpm/chrome.spec.template View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.trusty.arm View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.wheezy.arm View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M components/storage_monitor/udev_util_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_monitor_udev.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 5 chunks +25 lines, -21 lines 0 comments Download
M content/browser/udev_linux.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M device/hid/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/hid/device_monitor_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/hid/hid_connection_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/hid/input_service_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -4 lines 0 comments Download
M device/serial/serial.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M device/udev_linux/BUILD.gn View 1 1 chunk +8 lines, -3 lines 0 comments Download
M device/udev_linux/scoped_udev.h View 1 chunk +1 line, -2 lines 0 comments Download
A device/udev_linux/udev.h View 1 2 3 4 5 1 chunk +73 lines, -0 lines 0 comments Download
A device/udev_linux/udev.cc View 1 2 3 4 5 1 chunk +141 lines, -0 lines 0 comments Download
M device/udev_linux/udev.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
A device/udev_linux/udev0_loader.h View 1 2 3 4 5 1 chunk +79 lines, -0 lines 0 comments Download
A device/udev_linux/udev0_loader.cc View 1 2 3 4 5 1 chunk +165 lines, -0 lines 0 comments Download
A device/udev_linux/udev1_loader.h View 1 2 3 4 5 1 chunk +79 lines, -0 lines 0 comments Download
A device/udev_linux/udev1_loader.cc View 1 2 3 4 5 1 chunk +165 lines, -0 lines 0 comments Download
A device/udev_linux/udev_loader.h View 1 2 3 4 5 1 chunk +91 lines, -0 lines 0 comments Download
A device/udev_linux/udev_loader.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M device/usb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libusb/BUILD.gn View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/libusb/README.chromium View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libusb/libusb.gyp View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
A third_party/libusb/linux-udev.patch View 1 2 3 1 chunk +209 lines, -0 lines 0 comments Download
D third_party/libusb/src/libusb/os/linux_udev.c View 1 1 chunk +0 lines, -306 lines 0 comments Download
A + third_party/libusb/src/libusb/os/linux_udev.cc View 1 10 chunks +28 lines, -25 lines 0 comments Download
M third_party/libusb/src/libusb/os/linux_usbfs.h View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 1 2 3 4 5 7 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
Lei Zhang
reillyg: Care to take a first crack at reviewing this? Instead of accessing libudev.h, all ...
6 years, 1 month ago (2014-11-18 02:17:44 UTC) #3
Lei Zhang
Oh, and since we are no longer linking against libudev, any direct calls to udev ...
6 years, 1 month ago (2014-11-18 02:24:05 UTC) #4
Reilly Grant (use Gerrit)
lgtm
6 years, 1 month ago (2014-11-18 22:49:57 UTC) #5
Lei Zhang
Adding OWNERS: brettw: build/config/linux/BUILD.gn cpu: third_party/libudev - I added a copy of the libudev headers ...
6 years, 1 month ago (2014-11-18 23:31:24 UTC) #7
spang
lgtm
6 years, 1 month ago (2014-11-18 23:34:45 UTC) #8
Lei Zhang
+mmoss for additional changes in chrome/installer in patch set 9.
6 years, 1 month ago (2014-11-20 00:12:24 UTC) #10
Michael Moss
lgtm
6 years, 1 month ago (2014-11-20 00:17:56 UTC) #11
brettw
gn build lgtm
6 years, 1 month ago (2014-11-20 18:31:31 UTC) #12
cpu_(ooo_6.6-7.5)
if this is a new third party library (which appears to be) then we have ...
6 years, 1 month ago (2014-11-20 22:40:40 UTC) #13
Lei Zhang
On 2014/11/20 22:40:40, cpu wrote: > if this is a new third party library (which ...
6 years, 1 month ago (2014-11-20 23:12:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674703002/200001
6 years, 1 month ago (2014-11-22 01:51:34 UTC) #16
commit-bot: I haz the power
Committed patchset #10 (id:200001)
6 years, 1 month ago (2014-11-22 02:48:01 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 02:49:32 UTC) #18
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/ee816c278f12488490cb2e01fda46e4abab45af7
Cr-Commit-Position: refs/heads/master@{#305348}

Powered by Google App Engine
This is Rietveld 408576698