Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Issue 742293002: Linux: Add libudev headers to third_party/libudev. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
CC:
chromium-reviews, open-source-third-party-reviews_google.com, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux: Add libudev headers to third_party/libudev. BUG=435343 Committed: https://crrev.com/6caa50693b69a5fb4f4c3f5a4e077d054229836d Cr-Commit-Position: refs/heads/master@{#305314}

Patch Set 1 #

Patch Set 2 : re-upload with --similarity=0 #

Patch Set 3 : upload again with --similarity=100 --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+886 lines, -0 lines) Patch
A third_party/libudev/LICENSE View 1 2 1 chunk +502 lines, -0 lines 0 comments Download
A third_party/libudev/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/libudev/README.chromium View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/libudev/libudev0.h View 1 chunk +189 lines, -0 lines 0 comments Download
A third_party/libudev/libudev1.h View 1 chunk +185 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Lei Zhang
See bug for more details.
6 years, 1 month ago (2014-11-20 23:12:53 UTC) #2
Lei Zhang
+reillyg as well to be in the OWNERS file so I don't get lonely. I ...
6 years, 1 month ago (2014-11-20 23:17:26 UTC) #4
Reilly Grant (use Gerrit)
lgtm
6 years, 1 month ago (2014-11-20 23:21:22 UTC) #5
cpu_(ooo_6.6-7.5)
this https://codereview.chromium.org/742293002/diff/1/third_party/libudev/LICENSE gives me "Bad content. Try to upload again."
6 years, 1 month ago (2014-11-21 20:37:35 UTC) #6
Lei Zhang
On 2014/11/21 20:37:35, cpu wrote: > this > https://codereview.chromium.org/742293002/diff/1/third_party/libudev/LICENSE > > gives me "Bad content. ...
6 years, 1 month ago (2014-11-21 20:49:43 UTC) #7
Lei Zhang
On 2014/11/21 20:49:43, Lei Zhang wrote: > On 2014/11/21 20:37:35, cpu wrote: > > this ...
6 years, 1 month ago (2014-11-21 20:55:06 UTC) #8
cpu_(ooo_6.6-7.5)
lgtm on my side gated on the open source license people approving this.
6 years, 1 month ago (2014-11-21 21:49:06 UTC) #9
Lei Zhang
+open-source-third-party-reviews@google.com +jschuh FYI for security. We are already using libudev and this is just adding ...
6 years, 1 month ago (2014-11-21 21:53:26 UTC) #10
chromium-reviews
LGTM On Fri Nov 21 2014 at 1:53:26 PM <thestig@chromium.org> wrote: > +open-source-third-party-reviews@google.com > > ...
6 years, 1 month ago (2014-11-21 22:41:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742293002/40001
6 years, 1 month ago (2014-11-21 22:42:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-21 23:23:41 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 23:24:28 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6caa50693b69a5fb4f4c3f5a4e077d054229836d
Cr-Commit-Position: refs/heads/master@{#305314}

Powered by Google App Engine
This is Rietveld 408576698