chrome/installer/linux/rpm/build.sh - Issue 674703002: Linux: Dynamically load libudev.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/linux/rpm/build.sh

Issue 674703002: Linux: Dynamically load libudev. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoped_udev

Patch Set: rebase to head, which includes third_party/libudev already Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/linux/rpm/build.sh

diff --git a/chrome/installer/linux/rpm/build.sh b/chrome/installer/linux/rpm/build.sh

index ff54b952cbd6b470c0f1929edbc65041a1ffd9d1..70e9541587ed783d95d254ec173ba9255abcdeed 100755

--- a/chrome/installer/linux/rpm/build.sh

+++ b/chrome/installer/linux/rpm/build.sh

@@ -99,9 +99,7 @@ do_package() {

# Use find-requires script to make sure the dependencies are complete

# (especially libc and libstdc++ versions).

- # - Filter out udev to avoid libudev.so.0 vs. libudev.so.1 mismatches.

- DETECTED_DEPENDS="$(echo "${BUILDDIR}/chrome" | /usr/lib/rpm/find-requires |

- grep -v udev)"

+ DETECTED_DEPENDS="$(echo "${BUILDDIR}/chrome" | /usr/lib/rpm/find-requires)"

# Compare the expected dependency list to the generated list.

BAD_DIFF=0