Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 674023002: Fix name/path separator for telemetry_unittests test names. (Closed)

Created:
6 years, 2 months ago by Dirk Pranke
Modified:
6 years, 2 months ago
Reviewers:
szager1, ojan
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, Paweł Hajdan Jr., jam, szager1
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Fix name/path separator for telemetry_unittests test names. Previously we were using the hard-coded '/' separator for components of a test name (which was what the layout tests use), but telemetry uses '.' instead. R=ojan@chromium.org BUG=399371, 425694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292664

Patch Set 1 : initial patch for review #

Total comments: 1

Patch Set 2 : fix --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -16 lines) Patch
M scripts/slave/recipe_modules/json/api.py View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/json/test_api.py View 2 chunks +11 lines, -9 lines 0 comments Download
M scripts/slave/recipe_modules/json/util.py View 1 chunk +7 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 chunk +15 lines, -0 lines 0 comments Download
A scripts/slave/recipes/chromium_trybot.expected/telemetry_failures.json View 1 1 chunk +515 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
Ojan, please take a look? Note that the test format does currently contain a 'path_separator' ...
6 years, 2 months ago (2014-10-24 00:15:23 UTC) #4
szager1
It looks good to me, but the changes to the test expectations look weird. Can ...
6 years, 2 months ago (2014-10-24 20:26:06 UTC) #6
Dirk Pranke
On 2014/10/24 20:26:06, szager1 wrote: > It looks good to me, but the changes to ...
6 years, 2 months ago (2014-10-24 20:43:20 UTC) #7
Dirk Pranke
fixed ...
6 years, 2 months ago (2014-10-24 20:44:50 UTC) #8
szager1
lgtm
6 years, 2 months ago (2014-10-24 20:54:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674023002/80001
6 years, 2 months ago (2014-10-24 20:58:29 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 21:00:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as 292664

Powered by Google App Engine
This is Rietveld 408576698