scripts/slave/recipe_modules/json/api.py - Issue 674023002: Fix name/path separator for telemetry_unittests test names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/json/api.py

Issue 674023002: Fix name/path separator for telemetry_unittests test names. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: fix --no-find-copies Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/json/api.py

diff --git a/scripts/slave/recipe_modules/json/api.py b/scripts/slave/recipe_modules/json/api.py

index 3bb43d7968db87c95927cd3a4e46be9d9d4b54d1..cc215805284efe572e7cbbaadc9a11dd9b5dfd7f 100644

--- a/scripts/slave/recipe_modules/json/api.py

+++ b/scripts/slave/recipe_modules/json/api.py

@@ -82,7 +82,6 @@ class JsonOutputPlaceholder(recipe_util.Placeholder):

return ret

-# TODO(phajdan.jr): Rename to LayoutTestResultsOutputPlaceholder.

class TestResultsOutputPlaceholder(JsonOutputPlaceholder):

def result(self, presentation, test):

ret = super(TestResultsOutputPlaceholder, self).result(presentation, test)

@@ -118,7 +117,6 @@ class JsonApi(recipe_api.RecipeApi):

"""A placeholder which will expand to '/tmp/file'."""

return JsonOutputPlaceholder(self, add_json_log)

- # TODO(phajdan.jr): Rename to layout_test_results.

@recipe_util.returns_placeholder

def test_results(self, add_json_log=True):

"""A placeholder which will expand to '/tmp/file'.

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/json/test_api.py » ('j') | no next file with comments »