scripts/slave/recipes/chromium_trybot.py - Issue 674023002: Fix name/path separator for telemetry_unittests test names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 674023002: Fix name/path separator for telemetry_unittests test names. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: fix --no-find-copies Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/json/util.py ('k') | scripts/slave/recipes/chromium_trybot.expected/telemetry_failures.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 4b75e1caff15e77ee4fa56f6e9a7147c2dce801e..ebdf20d829ae05d0351b141d2c24b6fc8e66b8b2 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -1552,3 +1552,18 @@ def GenTests(api):

'targets': ['browser_tests', 'base_unittests'],

'build_targets': ['base_unittests']}))

)

+ # Test what happens if a telemetry test fails (we're testing that the

+ # test names that need to be retried are in the 'foo.bar' format rather

+ # than 'foo/bar').

+ yield (

+ api.test('telemetry_failures') +

+ props(buildername='linux_chromium_rel') +

+ api.platform.name('linux') +

+ api.override_step_data('telemetry_unittests (with patch)',

+ api.json.canned_test_output(passing=False, minimal=True,

+ path_separator='.')) +

+ api.override_step_data('telemetry_unittests (without patch)',

+ api.json.canned_test_output(passing=False, minimal=True,

+ path_separator='.'))

+ )