Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 673933002: Correctly set tab.active not tab.selected in the chrome.sessions API. (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correctly set tab.active not tab.selected in the chrome.sessions API. R=zea@chromium.org Committed: https://crrev.com/3a4f7643367292cf39a75393ea4c36de1fd78119 Cr-Commit-Position: refs/heads/master@{#301018}

Patch Set 1 #

Patch Set 2 : test #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/browser/extensions/api/sessions/sessions_api.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Nicolas Zea
Update the test expectations in sessions_apitest?
6 years, 2 months ago (2014-10-23 22:01:33 UTC) #1
not at google - send to devlin
6 years, 2 months ago (2014-10-23 22:03:27 UTC) #2
not at google - send to devlin
You were too quick for me. PTAL.
6 years, 2 months ago (2014-10-23 22:06:08 UTC) #3
Nicolas Zea
lgtm https://codereview.chromium.org/673933002/diff/20001/chrome/browser/extensions/api/sessions/sessions_apitest.cc File chrome/browser/extensions/api/sessions/sessions_apitest.cc (right): https://codereview.chromium.org/673933002/diff/20001/chrome/browser/extensions/api/sessions/sessions_apitest.cc#newcode260 chrome/browser/extensions/api/sessions/sessions_apitest.cc:260: EXPECT_EQ(j == 0, utils::GetBoolean(tab, "active")); nit: comment that ...
6 years, 2 months ago (2014-10-23 22:08:24 UTC) #4
not at google - send to devlin
https://codereview.chromium.org/673933002/diff/20001/chrome/browser/extensions/api/sessions/sessions_apitest.cc File chrome/browser/extensions/api/sessions/sessions_apitest.cc (right): https://codereview.chromium.org/673933002/diff/20001/chrome/browser/extensions/api/sessions/sessions_apitest.cc#newcode260 chrome/browser/extensions/api/sessions/sessions_apitest.cc:260: EXPECT_EQ(j == 0, utils::GetBoolean(tab, "active")); On 2014/10/23 22:08:23, Nicolas ...
6 years, 2 months ago (2014-10-23 22:15:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673933002/40001
6 years, 2 months ago (2014-10-23 22:19:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-24 01:40:22 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 01:41:04 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3a4f7643367292cf39a75393ea4c36de1fd78119
Cr-Commit-Position: refs/heads/master@{#301018}

Powered by Google App Engine
This is Rietveld 408576698