Correctly set tab.active not tab.selected in the chrome.sessions API.

chrome/browser/extensions/api/sessions/sessions_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/sessions/sessions_api.h"
 
 #include <vector>
 
 #include "base/i18n/rtl.h"
 #include "base/lazy_instance.h"
@@ skipping 79 matching lines @@
   if (!title.empty()) {
     tab_struct->title.reset(new std::string(title));
   } else {
     const std::string languages =
         profile->GetPrefs()->GetString(prefs::kAcceptLanguages);
     tab_struct->title.reset(
         new std::string(base::UTF16ToUTF8(net::FormatUrl(url, languages))));
   }
   tab_struct->index = index;
   tab_struct->pinned = pinned;
-  tab_struct->selected = index == selected_index;
-  tab_struct->active = false;
-  // TODO(kalman): Really? Docs say that selected is deprecated and to use
-  // highlighted instead, but here we're setting selected but not highlighted.
-  // Are they supposed to be the same or not?
-  tab_struct->highlighted = false;
-  tab_struct->incognito = false;
+  // Note: |selected_index| from the sync sessions model is what we call
+  // "active" in extensions terminology.  "selected" is deprecated because it's
+  // not clear whether it means "active" (user can see) or "highlighted" (user
+  // has highlighted, since you can select tabs without bringing them into the
+  // foreground).
+  tab_struct->active = index == selected_index;
   ExtensionTabUtil::ScrubTabForExtension(extension, tab_struct.get());
   return tab_struct.Pass();
 }
 
 scoped_ptr<windows::Window> CreateWindowModelHelper(
     scoped_ptr<std::vector<linked_ptr<tabs::Tab> > > tabs,
     const std::string& session_id,
     const windows::Window::Type& type,
     const windows::Window::State& state) {
   scoped_ptr<windows::Window> window_struct(new windows::Window);
@@ skipping 531 matching lines @@
   return g_factory.Pointer();
 }
 
 void SessionsAPI::OnListenerAdded(const EventListenerInfo& details) {
   sessions_event_router_.reset(
       new SessionsEventRouter(Profile::FromBrowserContext(browser_context_)));
   EventRouter::Get(browser_context_)->UnregisterObserver(this);
 }
 
 }  // namespace extensions