Correctly set tab.active not tab.selected in the chrome.sessions API.

chrome/browser/extensions/api/sessions/sessions_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/sessions/sessions_api.h"
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
@@ skipping 239 matching lines @@
     // Only the tabs are interesting.
     const base::ListValue* tabs = NULL;
     EXPECT_TRUE(window->GetList("tabs", &tabs));
     EXPECT_EQ(arraysize(kTabIDs), tabs->GetSize());
     for (size_t j = 0; j < tabs->GetSize(); ++j) {
       const base::DictionaryValue* tab = NULL;
       EXPECT_TRUE(tabs->GetDictionary(j, &tab));
       EXPECT_FALSE(tab->HasKey("id"));  // sessions API does not give tab IDs
       EXPECT_EQ(static_cast<int>(j), utils::GetInteger(tab, "index"));
       EXPECT_EQ(0, utils::GetInteger(tab, "windowId"));
-      EXPECT_EQ(true, utils::GetBoolean(tab, "pinned"));
+      EXPECT_EQ(j == 0, utils::GetBoolean(tab, "active"));

[Nicolas Zea, 2014/10/23 22:08:23]

nit: comment that the first tab is always the tab being viewed.

[not at google - send to devlin, 2014/10/23 22:15:10]

Done.

+      EXPECT_FALSE(utils::GetBoolean(tab, "selected"));
+      EXPECT_FALSE(utils::GetBoolean(tab, "highlighted"));
+      EXPECT_FALSE(utils::GetBoolean(tab, "incognito"));
+      EXPECT_TRUE(utils::GetBoolean(tab, "pinned"));
       EXPECT_EQ("http://foo/1", utils::GetString(tab, "url"));
       EXPECT_EQ("MyTitle", utils::GetString(tab, "title"));
       EXPECT_EQ("http://foo/favicon.ico", utils::GetString(tab, "favIconUrl"));
       EXPECT_EQ(base::StringPrintf("%s.%d", kSessionTags[i], kTabIDs[j]),
                 utils::GetString(tab, "sessionId"));
     }
   }
   return testing::AssertionSuccess();
 }
 
@@ skipping 109 matching lines @@
     return;
 #endif
 
   ASSERT_TRUE(RunExtensionSubtest("sessions",
                                   "sessions.html")) << message_;
 }
 
 }  // namespace
 
 }  // namespace extensions