Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 673783002: Subzero: Improve debugging controls, plus minor refactoring. (Closed)

Created:
6 years, 2 months ago by Jim Stichnoth
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Improve debugging controls, plus minor refactoring. 1. Decorate the list of live-in and live-out variables with register assignments in the dump() output. This helps one to assess register pressure. 2. Fix a bug where the DisableInternal flag wasn't being honored for function definitions. 3. Add a -translate-only=<symbol> to limit translation to a single function or global variable. This makes it easier to focus on debugging a single function. 4. Change the -no-phi-edge-split option to -phi-edge-split and invert the meaning, to better not avoid the non double negatives. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=088b2be278dde516d097caec0d1bfb5c47e7bb04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -38 lines) Patch
M src/IceCfg.cpp View 5 chunks +2 lines, -12 lines 0 comments Download
M src/IceCfgNode.cpp View 4 chunks +14 lines, -6 lines 0 comments Download
M src/IceClFlags.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceInstX8632.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/IceLiveness.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/IceOperand.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTranslator.cpp View 4 chunks +24 lines, -5 lines 0 comments Download
M src/llvm2ice.cpp View 4 chunks +8 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/phi.ll View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Jim Stichnoth
6 years, 2 months ago (2014-10-23 13:40:26 UTC) #2
jvoung (off chromium)
LGTM but would be good to summarize a bit some of the changes in the ...
6 years, 2 months ago (2014-10-23 15:44:20 UTC) #3
Jim Stichnoth
On 2014/10/23 15:44:20, jvoung wrote: > LGTM but would be good to summarize a bit ...
6 years, 2 months ago (2014-10-23 15:54:01 UTC) #4
jvoung (off chromium)
On 2014/10/23 15:54:01, stichnot wrote: > On 2014/10/23 15:44:20, jvoung wrote: > > LGTM but ...
6 years, 2 months ago (2014-10-23 17:09:51 UTC) #5
Jim Stichnoth
6 years, 2 months ago (2014-10-23 19:02:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
088b2be278dde516d097caec0d1bfb5c47e7bb04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698