src/IceInstX8632.cpp - Issue 673783002: Subzero: Improve debugging controls, plus minor refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8632.cpp

Issue 673783002: Subzero: Improve debugging controls, plus minor refactoring. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8632.cpp

diff --git a/src/IceInstX8632.cpp b/src/IceInstX8632.cpp

index dbacd58a87bdcb65a911de3849a96ea7c20692c6..94198669c46080a56fd50d1b90ca68e5a1414116 100644

--- a/src/IceInstX8632.cpp

+++ b/src/IceInstX8632.cpp

@@ -136,9 +136,7 @@ InstX8632Label::InstX8632Label(Cfg *Func, TargetX8632 *Target)

Number(Target->makeNextLabelNumber()) {}

IceString InstX8632Label::getName(const Cfg *Func) const {

- char buf[30];

- snprintf(buf, llvm::array_lengthof(buf), "%u", Number);

- return ".L" + Func->getFunctionName() + "$local$__" + buf;

+ return ".L" + Func->getFunctionName() + "$local$__" + std::to_string(Number);

}

InstX8632Br::InstX8632Br(Cfg *Func, const CfgNode *TargetTrue,

« no previous file with comments | « src/IceClFlags.h ('k') | src/IceLiveness.cpp » ('j') | no next file with comments »