src/IceTargetLoweringX8632.cpp - Issue 673783002: Subzero: Improve debugging controls, plus minor refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 673783002: Subzero: Improve debugging controls, plus minor refactoring. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index 98b18dc1c3ee559193b313c404c70d27cd5a944f..8ea5882ae282de3959030d59e79f219605547df6 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -4451,7 +4451,7 @@ void TargetGlobalInitX8632::lower(const VariableDeclaration &Var) {

// If external and not initialized, this must be a cross test.

// Don't generate a declaration for such cases.

- bool IsExternal = Var.isExternal();

+ bool IsExternal = Var.isExternal() || Ctx->getFlags().DisableInternal;

if (IsExternal && !Var.hasInitializer()) return;

bool HasNonzeroInitializer = Var.hasNonzeroInitializer();

« no previous file with comments | « src/IceOperand.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »