Android: Do not build any extensions code except for extensions_constants.

Android: Do not build any extensions code except for extensions_constants.

BUG=424746
Committed: https://crrev.com/52a87b3b54cffd55558d614ef45c78f796c18253
Cr-Commit-Position: refs/heads/master@{#300958}

[Lei Zhang, 2014-10-22 22:56:09]

Patchset #2 (id:20001) has been deleted

[Lei Zhang, 2014-10-22 22:56:13]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2014-10-22 22:58:00]

thestig@chromium.org changed reviewers:
+ yoz@chromium.org

[Lei Zhang, 2014-10-22 22:58:01]

I think this should be the end of extensions on Android. There will be some
follow-ups to cleanup TODOs.

This CL is still waiting on https://codereview.chromium.org/666283002/ BTW.

[Yoyo Zhou, 2014-10-23 00:04:00]

LGTM

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client.cc:1014: #endif
This endif and the one below should have a comment - especially since they're
nested and big.

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client_unittest.cc (right):

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client_unittest.cc:13: #include
"third_party/WebKit/public/platform/WebString.h"
Looks like you only need the webkit headers if !defined(DISABLE_NACL).

[Lei Zhang, 2014-10-23 00:30:46]

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client.cc:1014: #endif
On 2014/10/23 00:03:59, Yoyo Zhou wrote:
> This endif and the one below should have a comment - especially since they're
> nested and big.

Done.

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client_unittest.cc (right):

https://codereview.chromium.org/673663004/diff/40001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client_unittest.cc:13: #include
"third_party/WebKit/public/platform/WebString.h"
On 2014/10/23 00:03:59, Yoyo Zhou wrote:
> Looks like you only need the webkit headers if !defined(DISABLE_NACL).

Done.

[Lei Zhang, 2014-10-23 03:26:19]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-10-23 03:27:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673663004/80001

[commit-bot: I haz the power, 2014-10-23 03:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 03:46:15]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Lei Zhang, 2014-10-23 08:32:16]

thestig@chromium.org changed reviewers:
+ brettw@chromium.org

[Lei Zhang, 2014-10-23 08:32:17]

There's been some changes since patch set 3. PTAL.

+brettw for build/config/BUILD.gn and GN changes in general.

[brettw, 2014-10-23 20:02:57]

/build/config LGTM

[Lei Zhang, 2014-10-23 20:58:04]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-10-23 20:59:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673663004/190001

[commit-bot: I haz the power, 2014-10-23 22:02:50]

Committed patchset #9 (id:190001)

[commit-bot: I haz the power, 2014-10-23 22:03:39]

Patchset 9 (id:??) landed as
https://crrev.com/52a87b3b54cffd55558d614ef45c78f796c18253
Cr-Commit-Position: refs/heads/master@{#300958}