Android: Do not build any extensions code except for extensions_constants.

chrome/renderer/chrome_content_renderer_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <vector>
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/renderer/searchbox/search_bouncer.h"
 #include "content/public/common/webplugininfo.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/extension_builder.h"
-#include "extensions/common/manifest_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"

[Yoyo Zhou, 2014/10/23 00:03:59]

Looks like you only need the webkit headers if !defined(DISABLE_NACL).

[Lei Zhang, 2014/10/23 00:30:46]

Done.

 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "url/gurl.h"
 
+#if defined(ENABLE_EXTENSIONS)
+#include "extensions/common/extension.h"
+#include "extensions/common/extension_builder.h"
+#include "extensions/common/manifest_constants.h"
+#endif
+
 using blink::WebPluginParams;
 using blink::WebString;
 using blink::WebVector;
 using content::WebPluginInfo;
 using content::WebPluginMimeType;
 
 namespace {
 const bool kNaClRestricted = false;
 const bool kNaClUnrestricted = true;
 const bool kExtensionRestricted = false;
@@ skipping 12 matching lines @@
 
 const char kChatAppURL1[] = "https://foo.talkgadget.google.com/hangouts/foo";
 const char kChatAppURL2[] = "https://foo.plus.google.com/hangouts/foo";
 const char kChatAppURL3[] = "https://foo.plus.sandbox.google.com/hangouts/foo";
 const char kChatManifestFS1[] =
   "filesystem:https://foo.talkgadget.google.com/foo";
 const char kChatManifestFS2[] = "filesystem:https://foo.plus.google.com/foo";
 const char kChatManifestFS3[] =
   "filesystem:https://foo.plus.sandbox.google.com/foo";
 
+#if !defined(DISABLE_NACL)
 bool AllowsDevInterfaces(const WebPluginParams& params) {
   for (size_t i = 0; i < params.attributeNames.size(); ++i) {
     if (params.attributeNames[i] == WebString::fromUTF8("@dev"))
       return true;
   }
   return false;
 }
 
 void AddFakeDevAttribute(WebPluginParams* params) {
   WebVector<WebString> names(static_cast<size_t>(1));
   WebVector<WebString> values(static_cast<size_t>(1));
   names[0] = WebString::fromUTF8("@dev");
   values[0] = WebString();
   params->attributeNames.swap(names);
   params->attributeValues.swap(values);
 }
+#endif
 
 void AddContentTypeHandler(content::WebPluginInfo* info,
                            const char* mime_type,
                            const char* manifest_url) {
   content::WebPluginMimeType mime_type_info;
   mime_type_info.mime_type = mime_type;
   mime_type_info.additional_param_names.push_back(base::UTF8ToUTF16("nacl"));
   mime_type_info.additional_param_values.push_back(
       base::UTF8ToUTF16(manifest_url));
   info->mime_types.push_back(mime_type_info);
 }
 }  // namespace
 
 typedef testing::Test ChromeContentRendererClientTest;
 
 
+#if defined(ENABLE_EXTENSIONS)
 scoped_refptr<const extensions::Extension> CreateTestExtension(
     bool is_unrestricted, bool is_from_webstore, bool is_hosted_app,
     const std::string& app_url) {
   extensions::Manifest::Location location = is_unrestricted ?
       extensions::Manifest::UNPACKED :
       extensions::Manifest::INTERNAL;
   int flags = is_from_webstore ?
       extensions::Extension::FROM_WEBSTORE:
       extensions::Extension::NO_FLAGS;
 
@@ skipping 16 matching lines @@
     bool is_unrestricted, bool is_from_webstore) {
   return CreateTestExtension(
       is_unrestricted, is_from_webstore, kNotHostedApp, std::string());
 }
 
 scoped_refptr<const extensions::Extension> CreateHostedApp(
     bool is_unrestricted, bool is_from_webstore, const std::string& app_url) {
   return CreateTestExtension(is_unrestricted, is_from_webstore, kHostedApp,
                              app_url);
 }
+#endif  // defined(ENABLE_EXTENSIONS)
 
 TEST_F(ChromeContentRendererClientTest, NaClRestriction) {
   // Unknown content types have no NaCl module.
   {
     WebPluginInfo info;
     EXPECT_EQ(GURL(),
               ChromeContentRendererClient::GetNaClContentHandlerURL(
                   "application/x-foo", info));
   }
   // Known content types have a NaCl module.
   {
     WebPluginInfo info;
     AddContentTypeHandler(&info, "application/x-foo", "www.foo.com");
     EXPECT_EQ(GURL("www.foo.com"),
               ChromeContentRendererClient::GetNaClContentHandlerURL(
                   "application/x-foo", info));
   }
+#if !defined(DISABLE_NACL)
   // --enable-nacl allows all NaCl apps, with 'dev' interfaces.
   {
     WebPluginParams params;
     EXPECT_TRUE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(),
         GURL(),
         kNaClUnrestricted,
         CreateExtension(kExtensionRestricted, kExtensionNotFromWebStore).get(),
         &params));
     EXPECT_TRUE(AllowsDevInterfaces(params));
@@ skipping 217 matching lines @@
         &params));
     EXPECT_FALSE(ChromeContentRendererClient::IsNaClAllowed(
         GURL(),
         GURL("http://example.evil.com/test.html"),
         kNaClRestricted,
         CreateHostedApp(kExtensionRestricted,
                         kExtensionNotFromWebStore,
                         "http://example.com/").get(),
         &params));
   }
+#endif  // !defined(DISABLE_NACL)
 }
 
 TEST_F(ChromeContentRendererClientTest, AllowPepperMediaStreamAPI) {
   ChromeContentRendererClient test;
 #if !defined(OS_ANDROID)
   EXPECT_TRUE(test.AllowPepperMediaStreamAPI(GURL(kChatAppURL1)));
   EXPECT_TRUE(test.AllowPepperMediaStreamAPI(GURL(kChatAppURL2)));
   EXPECT_TRUE(test.AllowPepperMediaStreamAPI(GURL(kChatAppURL3)));
 #else
   EXPECT_FALSE(test.AllowPepperMediaStreamAPI(GURL(kChatAppURL1)));
   EXPECT_FALSE(test.AllowPepperMediaStreamAPI(GURL(kChatAppURL2)));
   EXPECT_FALSE(test.AllowPepperMediaStreamAPI(GURL(kChatAppURL3)));
 #endif
   EXPECT_FALSE(test.AllowPepperMediaStreamAPI(
       GURL("http://talkgadget.google.com/hangouts/foo")));
   EXPECT_FALSE(test.AllowPepperMediaStreamAPI(
       GURL("https://talkgadget.evil.com/hangouts/foo")));
 }
 
 TEST_F(ChromeContentRendererClientTest, ShouldSuppressErrorPage) {
   ChromeContentRendererClient client;
   client.search_bouncer_.reset(new SearchBouncer);
   client.search_bouncer_->OnSetSearchURLs(
       std::vector<GURL>(), GURL("http://example.com/n"));
   EXPECT_FALSE(client.ShouldSuppressErrorPage(NULL,
                                               GURL("http://example.com")));
   EXPECT_TRUE(client.ShouldSuppressErrorPage(NULL,
                                              GURL("http://example.com/n")));
 }