Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: extensions/common/BUILD.gn

Issue 673663004: Android: Do not build any extensions code except for extensions_constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zoom_controller
Patch Set: fix merge conflict Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/chrome_unit_test_suite.cc ('k') | extensions/common/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/BUILD.gn
diff --git a/extensions/common/BUILD.gn b/extensions/common/BUILD.gn
index 2bfebe6b371f8fb14f732ec25f1e2aa78f28212d..f4d6992b46afc708fc910152e63aa965a0db7d25 100644
--- a/extensions/common/BUILD.gn
+++ b/extensions/common/BUILD.gn
@@ -5,13 +5,6 @@
import("//build/config/features.gni")
import("//mojo/public/tools/bindings/mojom.gni")
-mojom("mojo") {
- sources = [
- "mojo/keep_alive.mojom",
- "stash.mojom",
- ]
-}
-
# GYP version: extensions/extensions.gyp:extensions_common_constants
source_set("common_constants") {
sources = [
@@ -26,6 +19,16 @@ source_set("common_constants") {
}
}
+if (enable_extensions) {
+
+mojom("mojo") {
+ sources = [
+ "mojo/keep_alive.mojom",
+ "stash.mojom",
+ ]
+}
+
+
# GYP version: extensions/extensions.gyp:extensions_common
source_set("common") {
sources = [
@@ -61,7 +64,6 @@ source_set("common") {
"extension.h",
"extension_api.cc",
"extension_api.h",
- "extension_api_stub.cc",
"extension_icon_set.cc",
"extension_icon_set.h",
"extension_l10n_util.cc",
@@ -226,7 +228,11 @@ source_set("common") {
"//components/url_matcher",
"//content/public/common",
"//crypto",
+ "//device/bluetooth",
+ "//device/usb",
+ "//extensions/common/api",
"//extensions/strings",
+ "//extensions:extensions_resources",
"//ipc",
"//net",
"//third_party/icu",
@@ -238,40 +244,6 @@ source_set("common") {
"//url",
]
- if (enable_extensions) {
- sources -= [
- "extension_api_stub.cc",
- ]
-
- deps += [
- "//device/bluetooth",
- "//device/usb",
- "//extensions/common/api",
- "//extensions:extensions_resources",
- ]
- } else {
- sources -= [
- "api/bluetooth/bluetooth_manifest_data.cc",
- "api/bluetooth/bluetooth_manifest_data.h",
- "api/bluetooth/bluetooth_manifest_handler.cc",
- "api/bluetooth/bluetooth_manifest_handler.h",
- "api/bluetooth/bluetooth_manifest_permission.cc",
- "api/bluetooth/bluetooth_manifest_permission.h",
- "api/messaging/message.h",
- "api/sockets/sockets_manifest_data.cc",
- "api/sockets/sockets_manifest_data.h",
- "api/sockets/sockets_manifest_handler.cc",
- "api/sockets/sockets_manifest_handler.h",
- "api/sockets/sockets_manifest_permission.cc",
- "api/sockets/sockets_manifest_permission.h",
- "extension_api.cc",
- "manifest_handlers/externally_connectable.cc",
- "manifest_handlers/externally_connectable.h",
- "manifest_handlers/options_page_info.cc",
- "manifest_handlers/options_page_info.h",
- ]
- }
-
if (enable_nacl) {
sources += [
"manifest_handlers/nacl_modules_handler.cc",
@@ -285,3 +257,5 @@ source_set("common") {
]
}
}
+
+} # enable_extensions
« no previous file with comments | « chrome/test/base/chrome_unit_test_suite.cc ('k') | extensions/common/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698