Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 673443003: Update fontMgr to take list of bcp47 language tags. (Closed)

Created:
6 years, 2 months ago by djsollen
Modified:
6 years, 2 months ago
Reviewers:
*bungeman-skia, *reed1, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update fontMgr to take list of bcp47 language tags. This will enable clients to pass more than one bcp47 tag to ensure that the most appropriate font is selected. BUG=422180

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits and loop fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -23 lines) Patch
M gm/fontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontMgr.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M include/ports/SkRemotableFontMgr.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkFontHost.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/fonts/SkFontMgr_indirect.cpp View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/ports/SkFontConfigParser_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 3 chunks +19 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
djsollen
first pass at the API
6 years, 2 months ago (2014-10-21 18:33:13 UTC) #3
reed1
https://codereview.chromium.org/673443003/diff/1/include/ports/SkFontMgr.h File include/ports/SkFontMgr.h (right): https://codereview.chromium.org/673443003/diff/1/include/ports/SkFontMgr.h#newcode74 include/ports/SkFontMgr.h:74: const char** bcp47, size_t bcpLength, nit: skia uses "int ...
6 years, 2 months ago (2014-10-21 19:03:42 UTC) #4
djsollen
nits addressed and loop in SkFontMgr_android fixed. https://codereview.chromium.org/673443003/diff/1/include/ports/SkFontMgr.h File include/ports/SkFontMgr.h (right): https://codereview.chromium.org/673443003/diff/1/include/ports/SkFontMgr.h#newcode74 include/ports/SkFontMgr.h:74: const char** ...
6 years, 2 months ago (2014-10-21 19:41:14 UTC) #5
bungeman-skia
6 years, 2 months ago (2014-10-23 16:58:47 UTC) #6
Message was sent while issue was closed.
Closing in favor of https://codereview.chromium.org/670243002 .

Powered by Google App Engine
This is Rietveld 408576698