Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 670243002: Update fontMgr to take list of bcp47 language tags. (Closed)

Created:
6 years, 2 months ago by bungeman-skia
Modified:
6 years, 2 months ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update fontMgr to take list of bcp47 language tags. This will enable clients to pass more than one bcp47 tag to ensure that the most appropriate font is selected. BUG=chromium:422180 Committed: https://skia.googlesource.com/skia/+/c20386e3937d3d398ac9b35f9c7d997e972ade98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -59 lines) Patch
M gm/fontmgr.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M include/ports/SkFontMgr.h View 2 chunks +19 lines, -3 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +10 lines, -2 lines 0 comments Download
M include/ports/SkRemotableFontMgr.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkFontHost.cpp View 2 chunks +20 lines, -4 lines 0 comments Download
M src/fonts/SkFontMgr_indirect.cpp View 1 chunk +15 lines, -3 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +62 lines, -33 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 2 chunks +18 lines, -4 lines 0 comments Download
M src/ports/SkRemotableFontMgr_win_dw.cpp View 3 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
The idea is to have the behavior change behind a flag, then on the Blink ...
6 years, 2 months ago (2014-10-22 23:08:59 UTC) #2
djsollen
lgtm
6 years, 2 months ago (2014-10-23 12:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670243002/1
6 years, 2 months ago (2014-10-23 13:58:03 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 14:08:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as c20386e3937d3d398ac9b35f9c7d997e972ade98

Powered by Google App Engine
This is Rietveld 408576698