include/ports/SkRemotableFontMgr.h - Issue 673443003: Update fontMgr to take list of bcp47 language tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/ports/SkRemotableFontMgr.h

Issue 673443003: Update fontMgr to take list of bcp47 language tags. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nits and loop fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/ports/SkRemotableFontMgr.h

diff --git a/include/ports/SkRemotableFontMgr.h b/include/ports/SkRemotableFontMgr.h

index bf2459955f5ce27d8bdaf25a2e2eb3cbde2baef1..8a19cd1957e64baf5a1a22157208972039930722 100644

--- a/include/ports/SkRemotableFontMgr.h

+++ b/include/ports/SkRemotableFontMgr.h

@@ -135,7 +135,8 @@ public:

* so it is fine to just pass a ISO 639 here.

virtual SkFontIdentity matchNameStyleCharacter(const char familyName[], const SkFontStyle&,

- const char bpc47[], SkUnichar character) const=0;

+ const char* bcp47[], int bcpLength,

+ SkUnichar character) const=0;

/**

* Returns the data for the given data id.

« no previous file with comments | « include/ports/SkFontMgr_indirect.h ('k') | src/core/SkFontHost.cpp » ('j') | no next file with comments »