Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 6731015: vpn-manager: accept a hostname for remote host (Closed)

Created:
9 years, 7 months ago by kmixter1
Modified:
9 years, 5 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, stevenjb
Visibility:
Public.

Description

vpn-manager: accept a hostname for remote host Change-Id: Iefe53207cf8df8bfbe32c3b69409348e23ac1bb2 BUG=chromium-os:13472 TEST=connect-vpn with remote host name instead of ip address Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c1578ee

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -58 lines) Patch
M ipsec_manager.h View 4 chunks +13 lines, -8 lines 1 comment Download
M ipsec_manager.cc View 6 chunks +48 lines, -32 lines 1 comment Download
M ipsec_manager_test.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M l2tp_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M l2tp_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M l2tp_manager_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M l2tpipsec_vpn.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kmixter1
9 years, 7 months ago (2011-03-24 08:24:29 UTC) #1
petkov
9 years, 7 months ago (2011-03-24 16:52:22 UTC) #2
LGTM

http://codereview.chromium.org/6731015/diff/1/ipsec_manager.cc
File ipsec_manager.cc (right):

http://codereview.chromium.org/6731015/diff/1/ipsec_manager.cc#newcode134
ipsec_manager.cc:134: // convert local_address to local_address_text.
Convert

http://codereview.chromium.org/6731015/diff/1/ipsec_manager.h
File ipsec_manager.h (right):

http://codereview.chromium.org/6731015/diff/1/ipsec_manager.h#newcode63
ipsec_manager.h:63: bool ConvertSockAddrToIPString(struct sockaddr*
socket_address,
can this be

const struct sockaddr&?

Powered by Google App Engine
This is Rietveld 408576698