Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: l2tp_manager_test.cc

Issue 6731015: vpn-manager: accept a hostname for remote host (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/vpn-manager.git@master
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ipsec_manager.cc ('K') | « l2tp_manager.cc ('k') | l2tpipsec_vpn.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: l2tp_manager_test.cc
diff --git a/l2tp_manager_test.cc b/l2tp_manager_test.cc
index a0b115d0784b60d1561478952d1c11edc916a3f5..90baed3705e663af5d694c430e0f202ba3d6e96a 100644
--- a/l2tp_manager_test.cc
+++ b/l2tp_manager_test.cc
@@ -28,7 +28,7 @@ class L2tpManagerTest : public ::testing::Test {
ServiceManager::temp_path_ = new FilePath(test_path_);
file_util::Delete(test_path_, true);
file_util::CreateDirectory(test_path_);
- remote_ = "1.2.3.4";
+ remote_hostname_ = "vpnserver";
control_path_ = test_path_.Append("control");
pppd_config_path_ = test_path_.Append("pppd.config");
ppp_interface_path_ = test_path_.Append("ppp0");
@@ -38,11 +38,11 @@ class L2tpManagerTest : public ::testing::Test {
l2tp_.ppp_interface_path_ = ppp_interface_path_;
FLAGS_pppd_plugin = "";
FLAGS_user = "me";
- EXPECT_TRUE(l2tp_.Initialize(remote_));
+ EXPECT_TRUE(l2tp_.Initialize(remote_hostname_));
}
protected:
- std::string remote_;
+ std::string remote_hostname_;
FilePath test_path_;
FilePath control_path_;
FilePath pppd_config_path_;
@@ -54,7 +54,7 @@ class L2tpManagerTest : public ::testing::Test {
TEST_F(L2tpManagerTest, FormatL2tpdConfiguration) {
static const char kBaseExpected[] =
"[lac managed]\n"
- "lns = 1.2.3.4\n"
+ "lns = vpnserver\n"
"require chap = yes\n"
"refuse pap = yes\n"
"require authentication = yes\n"
« ipsec_manager.cc ('K') | « l2tp_manager.cc ('k') | l2tpipsec_vpn.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698