vpn-manager: accept a hostname for remote host

l2tp_manager_test.cc

 // Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/process_mock.h"
 #include "chromeos/syslog_logging.h"
 #include "chromeos/test_helpers.h"
 #include "gflags/gflags.h"
 #include "gtest/gtest.h"
 
@@ skipping 10 matching lines @@
 using ::testing::InSequence;
 using ::testing::Return;
 
 class L2tpManagerTest : public ::testing::Test {
  public:
   void SetUp() {
     test_path_ = FilePath("test");
     ServiceManager::temp_path_ = new FilePath(test_path_);
     file_util::Delete(test_path_, true);
     file_util::CreateDirectory(test_path_);
-    remote_ = "1.2.3.4";
+    remote_hostname_ = "vpnserver";
     control_path_ = test_path_.Append("control");
     pppd_config_path_ = test_path_.Append("pppd.config");
     ppp_interface_path_ = test_path_.Append("ppp0");
     l2tpd_ = new ProcessMock;
     l2tp_.l2tpd_.reset(l2tpd_);
     l2tp_.l2tpd_control_path_ = control_path_;
     l2tp_.ppp_interface_path_ = ppp_interface_path_;
     FLAGS_pppd_plugin = "";
     FLAGS_user = "me";
-    EXPECT_TRUE(l2tp_.Initialize(remote_));
+    EXPECT_TRUE(l2tp_.Initialize(remote_hostname_));
   }
 
  protected:
-  std::string remote_;
+  std::string remote_hostname_;
   FilePath test_path_;
   FilePath control_path_;
   FilePath pppd_config_path_;
   FilePath ppp_interface_path_;
   L2tpManager l2tp_;
   ProcessMock* l2tpd_;
 };
 
 TEST_F(L2tpManagerTest, FormatL2tpdConfiguration) {
   static const char kBaseExpected[] =
       "[lac managed]\n"
-      "lns = 1.2.3.4\n"
+      "lns = vpnserver\n"
       "require chap = yes\n"
       "refuse pap = yes\n"
       "require authentication = yes\n"
       "name = me\n"
       "ppp debug = yes\n"
       "pppoptfile = test/pppd.config\n"
       "length bit = yes\n";
   EXPECT_EQ(kBaseExpected,
             l2tp_.FormatL2tpdConfiguration(pppd_config_path_.value()));
 }
@@ skipping 103 matching lines @@
 
 TEST_F(L2tpManagerTest, PollNothingIfRunning) {
   l2tp_.is_running_ = true;
   EXPECT_EQ(-1, l2tp_.Poll());
 }
 
 int main(int argc, char** argv) {
   SetUpTests(&argc, argv, true);
   return RUN_ALL_TESTS();
 }