Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 672973002: ThreadWacther - delete the code for Android that collected stats for (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, bulach, Feng Qian
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ThreadWacther - delete the code for Android that collected stats for StartupTimeBombAlarm. Added a TODO to enable StartupTimeBomb for Android. Reverting the following two CL's manaually: https://codereview.chromium.org/269763002 https://codereview.chromium.org/273963002 R=jar@chromium.org BUG=366699 Committed: https://crrev.com/9d4b477394fa54b89cda588c432da19b193d26a6 Cr-Commit-Position: refs/heads/master@{#300972}

Patch Set 1 #

Patch Set 2 : StartupTimeBomb.Alarm.* histograms obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M chrome/browser/metrics/thread_watcher.cc View 2 chunks +2 lines, -26 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-23 18:42:13 UTC) #1
jar (doing other things)
For histograms.xml, better is to <obsolete> the histograms.
6 years, 2 months ago (2014-10-23 19:55:32 UTC) #2
ramant (doing other things)
PTAL
6 years, 2 months ago (2014-10-23 20:21:23 UTC) #3
jar (doing other things)
lgtm
6 years, 2 months ago (2014-10-23 21:42:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672973002/20001
6 years, 2 months ago (2014-10-23 21:45:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 23:09:50 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:10:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d4b477394fa54b89cda588c432da19b193d26a6
Cr-Commit-Position: refs/heads/master@{#300972}

Powered by Google App Engine
This is Rietveld 408576698