Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 273963002: Added histograms to track duration when StartupTimeBomb goes off. (Closed)

Created:
6 years, 7 months ago by ramant (doing other things)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Added histograms to track duration when StartupTimeBomb goes off. When StartupTimebomb goes off, collect the duration stats (difference between when the timebomb went off and when it is started). We collect this duration in terms of clock time, montonic clock time and thread CPU time. BUG=366699 R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269602

Patch Set 1 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
Hi Jim, Would appreciate if you could take a look at histograms.xml changes (if I ...
6 years, 7 months ago (2014-05-09 01:05:09 UTC) #1
jar (doing other things)
lgtm Sorry if I missed the typo before. This looks perfect.
6 years, 7 months ago (2014-05-09 16:12:34 UTC) #2
ramant (doing other things)
On 2014/05/09 16:12:34, jar wrote: > lgtm > > Sorry if I missed the typo ...
6 years, 7 months ago (2014-05-09 16:12:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/273963002/20001
6 years, 7 months ago (2014-05-09 16:18:27 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 18:44:08 UTC) #5
Message was sent while issue was closed.
Change committed as 269602

Powered by Google App Engine
This is Rietveld 408576698