Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6605)

Unified Diff: chrome/browser/metrics/thread_watcher.cc

Issue 672973002: ThreadWacther - delete the code for Android that collected stats for (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: StartupTimeBomb.Alarm.* histograms obsolete Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher.cc
diff --git a/chrome/browser/metrics/thread_watcher.cc b/chrome/browser/metrics/thread_watcher.cc
index e3e36f1fae3d3c04c89bb47fcf00d121df72f787..9f6b7baf2b3d3aea0f3949ca952156997f1f3276 100644
--- a/chrome/browser/metrics/thread_watcher.cc
+++ b/chrome/browser/metrics/thread_watcher.cc
@@ -920,13 +920,6 @@ class StartupWatchDogThread : public base::Watchdog {
// alarming.
explicit StartupWatchDogThread(const base::TimeDelta& duration)
: base::Watchdog(duration, "Startup watchdog thread", true) {
-#if defined(OS_ANDROID)
- // TODO(rtenneti): Delete this code, after getting data.
- start_time_clock_= base::Time::Now();
- start_time_monotonic_ = base::TimeTicks::Now();
- start_time_thread_now_ = base::TimeTicks::IsThreadNowSupported()
- ? base::TimeTicks::ThreadNow() : base::TimeTicks::Now();
-#endif // OS_ANDROID
}
// Alarm is called if the time expires after an Arm() without someone calling
@@ -939,29 +932,12 @@ class StartupWatchDogThread : public base::Watchdog {
#elif !defined(OS_ANDROID)
WatchDogThread::PostTask(FROM_HERE, base::Bind(&StartupHang));
return;
-#else // Android release: gather stats to figure out when to crash.
- // TODO(rtenneti): Delete this code, after getting data.
- UMA_HISTOGRAM_TIMES("StartupTimeBomb.Alarm.TimeDuration",
- base::Time::Now() - start_time_clock_);
- UMA_HISTOGRAM_TIMES("StartupTimeBomb.Alarm.TimeTicksDuration",
- base::TimeTicks::Now() - start_time_monotonic_);
- if (base::TimeTicks::IsThreadNowSupported()) {
- UMA_HISTOGRAM_TIMES(
- "StartupTimeBomb.Alarm.ThreadNowDuration",
- base::TimeTicks::ThreadNow() - start_time_thread_now_);
- }
- return;
+#else
+ // TODO(rtenneti): Enable crashing for Android.
#endif // OS_ANDROID
}
private:
-#if defined(OS_ANDROID)
- // TODO(rtenneti): Delete this code, after getting data.
- base::Time start_time_clock_;
- base::TimeTicks start_time_monotonic_;
- base::TimeTicks start_time_thread_now_;
-#endif // OS_ANDROID
-
DISALLOW_COPY_AND_ASSIGN(StartupWatchDogThread);
};
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698