Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/renderer/render_widget.h

Issue 671503005: Plumb composition character bounds for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 6b17db72626472716d0e6bcb745d0e3d71482549..1ee18a45c6c14b65b7d9e98874b859a87588d92a 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -292,10 +292,11 @@ class CONTENT_EXPORT RenderWidget
void UpdateTextInputState(ShowIme show_ime, ChangeSource change_source);
#endif
-#if defined(OS_MACOSX) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA) || defined(OS_ANDROID)
// Checks if the composition range or composition character bounds have been
// changed. If they are changed, the new value will be sent to the browser
- // process.
+ // process. This method does nothing when the browser process is not able to
+ // handle composition range and composition character bounds.
void UpdateCompositionInfo(bool should_update_range);
#endif
@@ -471,7 +472,7 @@ class CONTENT_EXPORT RenderWidget
virtual ui::TextInputType WebKitToUiTextInputType(
blink::WebTextInputType type);
-#if defined(OS_MACOSX) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA) || defined(OS_ANDROID)
// Override point to obtain that the current composition character bounds.
// In the case of surrogate pairs, the character is treated as two characters:
// the bounds for first character is actual one, and the bounds for second

Powered by Google App Engine
This is Rietveld 408576698