Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 671503005: Plumb composition character bounds for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 0343568ec2c0dc9894f4907a15c3e6a0a17e1b25..3cf9d89cda3f977bc3de256a0c3d2c7a6bc2410a 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -760,6 +760,12 @@ void RenderWidgetHostViewAndroid::ImeCancelComposition() {
ime_adapter_android_.CancelComposition();
}
+void RenderWidgetHostViewAndroid::ImeCompositionRangeChanged(
+ const gfx::Range& range,
+ const std::vector<gfx::Rect>& character_bounds) {
+ // TODO(yukawa): Implement this.
Mike West 2014/10/25 05:59:53 It doesn't look like the existing implementation i
sky 2014/10/27 15:28:32 NOTIMPLEMENTED?
yukawa 2014/10/27 16:10:29 Acknowledged.
yukawa 2014/10/27 16:10:29 Thanks but let me keep this as a comment. I'd like
+}
+
void RenderWidgetHostViewAndroid::FocusedNodeChanged(bool is_editable_node) {
ime_adapter_android_.FocusedNodeChanged(is_editable_node);
if (selection_controller_)

Powered by Google App Engine
This is Rietveld 408576698