content/renderer/render_view_impl.cc - Issue 671503005: Plumb composition character bounds for Android 5.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 671503005: Plumb composition character bounds for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index a533f8d3fb956a46f925c2015d757b8803ddea6d..b273c62567b7ada76d7b577e79fd0ecf10fcf627 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3738,7 +3738,7 @@ void RenderViewImpl::GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) {

RenderWidget::GetSelectionBounds(start, end);

}

-#if defined(OS_MACOSX) || defined(USE_AURA)

+#if defined(OS_MACOSX) || defined(USE_AURA) || defined(OS_ANDROID)

void RenderViewImpl::GetCompositionCharacterBounds(

std::vector<gfx::Rect>* bounds) {

DCHECK(bounds);