Preserve marking bits across scavenges if incremental marker is running.

Preserve marking bits across scavenges if incremental marker is running.

This avoids hurry if incremental marking did not complete before scavenge.

Committed: http://code.google.com/p/v8/source/detail?r=7332

[Erik Corry, 2011-03-23 12:04:32]

LGTM

http://codereview.chromium.org/6715028/diff/8/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/6715028/diff/8/src/heap.cc#newcode476
src/heap.cc:476: PrintF("[IncrementalMarking] SURVIVING SCAVENGE\n");
This is a message that makes sense in terms of the current change, but will not
make much sense in the future.  I suggest instead "SCAVENGE DURING INCREMENTAL
MARKING".  Also consider losing the ALL CAPS for this and the other messages.

http://codereview.chromium.org/6715028/diff/8/src/heap.cc#newcode1249
src/heap.cc:1249: typedef ObjectEvacuationStrategy<POINTER_OBJECT> PtrObj;
Is this an object or a strategy?  Perhaps it should be called PtrStrategy?

http://codereview.chromium.org/6715028/diff/8/src/incremental-marking.h
File src/incremental-marking.h (right):

http://codereview.chromium.org/6715028/diff/8/src/incremental-marking.h#newco...
src/incremental-marking.h:142: static inline void BlackToGrey(HeapObject* obj,
MarkBit mark_bit) {
Peraps this should be called BlackToGreyAndPush and the next should be called
WhiteToGreyAndPush, thwn MarkWhiteObjectGrey can be called just WhiteToGrey?

[Erik Corry, 2011-03-23 15:58:51]

Still LGTM