Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3039)

Unified Diff: src/spaces.cc

Issue 6715028: Preserve marking bits across scavenges if incremental marker is running. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: fix review comments, add more tracing Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-visiting.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces.cc
diff --git a/src/spaces.cc b/src/spaces.cc
index c78522bf4e14724413837c5f7725cfb008cb5917..b3a31100da4129b8a50cc1b2c378691d3d874126 100644
--- a/src/spaces.cc
+++ b/src/spaces.cc
@@ -87,6 +87,9 @@ void HeapObjectIterator::Initialize(PagedSpace* space,
Address cur, Address end,
HeapObjectIterator::PageMode mode,
HeapObjectCallback size_f) {
+ // Check that we actually can iterate this space.
+ ASSERT(!space->was_swept_conservatively());
+
space_ = space;
cur_addr_ = cur;
cur_end_ = end;
@@ -116,7 +119,6 @@ bool HeapObjectIterator::AdvanceToNextPage() {
cur_addr_ = cur_page->ObjectAreaStart();
cur_end_ = cur_page->ObjectAreaEnd();
ASSERT(!cur_page->IsFlagSet(Page::WAS_SWEPT_CONSERVATIVELY));
- ASSERT(IncrementalMarking::state() == IncrementalMarking::STOPPED);
return true;
}
« no previous file with comments | « src/objects-visiting.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698