Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671463002: DevTools: make flame chart a web component. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
caseq, lushnikov, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: make flame chart a web component. BUG=417275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184268

Patch Set 1 #

Total comments: 2

Patch Set 2 : for landing #

Patch Set 3 : rebaselined #

Patch Set 4 : test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -174 lines) Patch
M Source/devtools/front_end/components/FlameChart.js View 1 2 5 chunks +14 lines, -14 lines 0 comments Download
M Source/devtools/front_end/components/HelpScreen.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/components/flameChart.css View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M Source/devtools/front_end/components/helpScreen.css View 1 5 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/host/Platform.js View 1 chunk +0 lines, -49 lines 0 comments Download
M Source/devtools/front_end/inspectorCommon.css View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 8 chunks +15 lines, -35 lines 0 comments Download
M Source/devtools/front_end/main/HelpScreenUntilReload.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/profiler/profilesPanel.css View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/DOMExtension.js View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/Popover.js View 1 2 6 chunks +6 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 2 1 chunk +16 lines, -9 lines 0 comments Download
M Source/devtools/front_end/ui/View.js View 1 2 4 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pfeldman
6 years, 2 months ago (2014-10-20 16:50:35 UTC) #2
yurys
https://codereview.chromium.org/671463002/diff/1/Source/devtools/front_end/ui/View.js File Source/devtools/front_end/ui/View.js (right): https://codereview.chromium.org/671463002/diff/1/Source/devtools/front_end/ui/View.js#newcode38 Source/devtools/front_end/ui/View.js:38: this._shadowRoot = this.element.createShadowRoot(); What's the point in having this ...
6 years, 2 months ago (2014-10-21 04:28:34 UTC) #4
pfeldman
https://codereview.chromium.org/671463002/diff/1/Source/devtools/front_end/ui/View.js File Source/devtools/front_end/ui/View.js (right): https://codereview.chromium.org/671463002/diff/1/Source/devtools/front_end/ui/View.js#newcode38 Source/devtools/front_end/ui/View.js:38: this._shadowRoot = this.element.createShadowRoot(); Lets leave it here for the ...
6 years, 2 months ago (2014-10-22 09:32:49 UTC) #5
yurys
lgtm
6 years, 2 months ago (2014-10-22 09:41:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671463002/40001
6 years, 2 months ago (2014-10-22 17:12:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/30465)
6 years, 2 months ago (2014-10-22 18:13:01 UTC) #10
caseq
lgtm
6 years, 2 months ago (2014-10-23 12:13:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671463002/60001
6 years, 2 months ago (2014-10-23 12:16:02 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 14:12:25 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 184268

Powered by Google App Engine
This is Rietveld 408576698