Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: Source/devtools/front_end/ui/DOMExtension.js

Issue 671463002: DevTools: make flame chart a web component. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test fixed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/toolbox_bootstrap/Toolbox.js ('k') | Source/devtools/front_end/ui/Popover.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/DOMExtension.js
diff --git a/Source/devtools/front_end/ui/DOMExtension.js b/Source/devtools/front_end/ui/DOMExtension.js
index 55f021f6f0a9b0dbd1de750ba9106039e081cdeb..ff5133ca303321a15b6347fb26b83843aaad9f96 100644
--- a/Source/devtools/front_end/ui/DOMExtension.js
+++ b/Source/devtools/front_end/ui/DOMExtension.js
@@ -284,17 +284,13 @@ Element.prototype.measurePreferredSize = function(containerElement)
{
containerElement = containerElement || this.ownerDocument.body;
containerElement.appendChild(this);
- var fakingComponentRoot = false;
- if (!this.classList.contains("component-root")) {
- fakingComponentRoot = true;
- this.classList.add("component-root");
- }
+ var fakingComponentRoot = WebInspector.installComponentRootStyles(this);
this.positionAt(0, 0);
var result = new Size(this.offsetWidth, this.offsetHeight);
this.positionAt(undefined, undefined);
this.remove();
if (fakingComponentRoot)
- this.classList.remove("component-root");
+ WebInspector.uninstallComponentRootStyles(this);
return result;
}
« no previous file with comments | « Source/devtools/front_end/toolbox_bootstrap/Toolbox.js ('k') | Source/devtools/front_end/ui/Popover.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698