Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: Source/devtools/front_end/components/HelpScreen.js

Issue 671463002: DevTools: make flame chart a web component. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test fixed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/HelpScreen.js
diff --git a/Source/devtools/front_end/components/HelpScreen.js b/Source/devtools/front_end/components/HelpScreen.js
index 6aafb7d833e9bb5b94cda9edda945e0c7a47b5bd..eb4c4f0b5b88a1b456c54c529ad23a3c07360f03 100644
--- a/Source/devtools/front_end/components/HelpScreen.js
+++ b/Source/devtools/front_end/components/HelpScreen.js
@@ -47,7 +47,7 @@ WebInspector.HelpScreen = function(title)
var mainWindow = this.element.createChild("div", "help-window-main");
var captionWindow = mainWindow.createChild("div", "help-window-caption");
captionWindow.appendChild(this._createCloseButton());
- this.contentElement = mainWindow.createChild("div", "help-content");
+ this.helpContentElement = mainWindow.createChild("div", "help-content");
captionWindow.createChild("h1", "help-window-title").textContent = title;
}
}
@@ -123,7 +123,7 @@ WebInspector.HelpScreen.prototype = {
WebInspector.RemoteDebuggingTerminatedScreen = function(reason)
{
WebInspector.HelpScreen.call(this, WebInspector.UIString("Detached from the target"));
- var p = this.contentElement.createChild("p");
+ var p = this.helpContentElement.createChild("p");
p.classList.add("help-section");
p.createChild("span").textContent = WebInspector.UIString("Remote debugging has been terminated with reason: ");
p.createChild("span", "error-message").textContent = reason;
@@ -142,7 +142,7 @@ WebInspector.RemoteDebuggingTerminatedScreen.prototype = {
WebInspector.WorkerTerminatedScreen = function()
{
WebInspector.HelpScreen.call(this, WebInspector.UIString("Inspected worker terminated"));
- var p = this.contentElement.createChild("p");
+ var p = this.helpContentElement.createChild("p");
p.classList.add("help-section");
p.textContent = WebInspector.UIString("Inspected worker has terminated. Once it restarts we will attach to it automatically.");
}
« no previous file with comments | « Source/devtools/front_end/components/FlameChart.js ('k') | Source/devtools/front_end/components/flameChart.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698