Issue 671043004: [turbofan] cleanup register allocator interface a little

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671043004: [turbofan] cleanup register allocator interface a little (Closed)

Created:
6 years, 1 month ago by dcarney

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] cleanup register allocator interface a little BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24978

Patch Set 5 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -86 lines)			Patch
M	src/compiler/pipeline.cc	View	1 2 3 4	4 chunks	+28 lines, -5 lines	0 comments	Download
M	src/compiler/register-allocator.h	View	1 2 3 4	11 chunks	+41 lines, -47 lines	0 comments	Download
M	src/compiler/register-allocator.cc	View	1 3 4	8 chunks	+22 lines, -33 lines	0 comments	Download
M	test/cctest/compiler/test-codegen-deopt.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jarin

lgtm. https://codereview.chromium.org/671043004/diff/40001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/671043004/diff/40001/src/compiler/pipeline.cc#newcode573 src/compiler/pipeline.cc:573: #endif Could you extract the code above to ...

6 years, 1 month ago (2014-10-29 12:16:51 UTC) #2

dcarney

6 years, 1 month ago (2014-10-29 12:35:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as 24978 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 671043004: [turbofan] cleanup register allocator interface a little (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages