[turbofan] cleanup register allocator interface a little

src/compiler/pipeline.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/pipeline.h"
 
 #include <fstream>  // NOLINT(readability/streams)
 #include <sstream>
 
 #include "src/base/platform/elapsed-timer.h"
@@ skipping 538 matching lines @@
 
   // Allocate registers.
   Frame frame;
   {
     int node_count = sequence.VirtualRegisterCount();
     if (node_count > UnallocatedOperand::kMaxVirtualRegisters) {
       info()->AbortOptimization(kNotEnoughVirtualRegistersForValues);
       return Handle<Code>::null();
     }
     ZonePool::Scope zone_scope(data->zone_pool());
-    RegisterAllocator allocator(zone_scope.zone(), &frame, info(), &sequence);
+
+    const char* debug_name = NULL;
+#ifdef DEBUG
+    SmartArrayPointer<char> debug_name_chars;
+    if (info()->IsStub()) {
+      if (info()->code_stub() != NULL) {
+        CodeStub::Major major_key = info()->code_stub()->MajorKey();
+        debug_name = CodeStub::MajorName(major_key, false);
+      }
+    } else {
+      AllowHandleDereference allow_deref;
+      debug_name_chars = info()->function()->debug_name()->ToCString();
+      debug_name = debug_name_chars.get();
+    }
+#endif

[Jarin, 2014/10/29 12:16:51]

Could you extract the code above to a function and possibly reuse it in
Pipeline::GenerateCode(). (Hmm, why did we overload the 'GenerateCode' name?)

+
+    RegisterAllocator allocator(zone_scope.zone(), &frame, &sequence,
+                                debug_name);
     if (!allocator.Allocate(data->pipeline_statistics())) {
       info()->AbortOptimization(kNotEnoughVirtualRegistersRegalloc);
       return Handle<Code>::null();
     }
     if (FLAG_trace_turbo) {
       TurboCfgFile tcf(isolate());
       tcf << AsC1VAllocator("CodeGen", &allocator);
     }
   }
 
@@ skipping 30 matching lines @@
 }
 
 
 void Pipeline::TearDown() {
   InstructionOperand::TearDownCaches();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8