Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 670953006: Componentize HostContentSettingsMap and content settings providers. (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, stuartmorgan+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, posciak+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, davidben+watch_chromium.org, gavinp+prer_chromium.org, tfarina, mcasas+watch_chromium.org, peter+watch_chromium.org, wjia+watch_chromium.org, davemoore+watch_chromium.org, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Componentize HostContentSettingsMap and content settings providers. These files are mutually dependent via includes (default provider includes content_settings_util.h but content_settings_util.cc includes host_content_settings_map.h, for example). BUG=384869, 384876 R=bauerb@chromium.org, vabr@chromium.org TBR=sky@chromium.org, rch@chromium.org TEST=no functional changes, build succeeds Committed: https://crrev.com/8eaec82caaae926faedbfd7df0beb4979c3f6792 Cr-Commit-Position: refs/heads/master@{#301286}

Patch Set 1 #

Total comments: 15

Patch Set 2 : fix #

Patch Set 3 : GN fix #

Patch Set 4 : win64 suppress warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -3990 lines) Patch
M chrome/browser/android/banners/app_banner_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_custom_extension_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/content_settings/content_settings_default_provider.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/content_settings/content_settings_default_provider.cc View 1 chunk +0 lines, -340 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/content_settings/content_settings_mock_provider.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/content_settings/content_settings_mock_provider.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/content_settings/content_settings_override_provider.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/content_settings/content_settings_override_provider.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/content_settings/content_settings_policy_provider.h View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/content_settings/content_settings_policy_provider.cc View 1 chunk +0 lines, -495 lines 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/content_settings/content_settings_pref_provider.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/content_settings/content_settings_pref_provider.cc View 1 chunk +0 lines, -657 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/content_settings/content_settings_provider_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M chrome/browser/content_settings/content_settings_usages_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_usages_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/content_settings/content_settings_utils.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/content_settings/content_settings_utils.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D chrome/browser/content_settings/content_settings_utils_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/cookie_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/content_settings/host_content_settings_map.h View 1 chunk +0 lines, -363 lines 0 comments Download
D chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +0 lines, -747 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/mock_settings_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_queue_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_settings_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_device_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_profile_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_broker_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 4 chunks +1 line, -29 lines 0 comments Download
M chrome/common/pref_names.cc View 3 chunks +0 lines, -72 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_interactive_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M components/content_settings.gypi View 1 2 3 2 chunks +18 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 2 chunks +18 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_default_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_default_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_mock_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_mock_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/content_settings/core/browser/content_settings_override_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_override_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_policy_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_policy_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_pref_provider.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_pref_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_provider_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_utils.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/content_settings/core/browser/host_content_settings_map.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/content_settings/core/browser/host_content_settings_map.cc View 1 5 chunks +21 lines, -16 lines 0 comments Download
M components/content_settings/core/common/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A components/content_settings/core/common/pref_names.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/content_settings/core/common/pref_names.cc View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
Jun Mukai
6 years, 2 months ago (2014-10-23 20:48:07 UTC) #1
Jun Mukai
+R=blundell
6 years, 2 months ago (2014-10-23 20:49:15 UTC) #3
blundell
blundell@ -> vabr@. Vaclav is a better reviewer here.
6 years, 2 months ago (2014-10-24 06:45:47 UTC) #5
vabr (Chromium)
Thanks, Jun, this is awesome! LGTM with a couple of comments. Cheers, Vaclav https://codereview.chromium.org/670953006/diff/1/components/components_tests.gyp File ...
6 years, 2 months ago (2014-10-24 07:06:32 UTC) #6
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-10-24 08:50:25 UTC) #7
Jun Mukai
feel ashamed to send code review with WIP status of build files :-/ thanks for ...
6 years, 2 months ago (2014-10-24 21:17:02 UTC) #8
Jun Mukai
TBR with rch: for adding +net/base to components/content_settings/core/browser/DEPS sky: for the mechanical changes of include
6 years, 2 months ago (2014-10-24 21:19:08 UTC) #9
Jun Mukai
6 years, 2 months ago (2014-10-24 21:19:44 UTC) #11
Jun Mukai
resending... TBR with rch: for adding +net/base to components/content_settings/core/browser/DEPS sky: for the mechanical changes of ...
6 years, 2 months ago (2014-10-24 21:20:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670953006/40001
6 years, 2 months ago (2014-10-24 21:35:10 UTC) #14
Ryan Hamilton
net/ (aka components/content_settings/core/browser/DEPS) LGTM
6 years, 2 months ago (2014-10-24 22:47:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/9095)
6 years, 2 months ago (2014-10-24 22:50:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670953006/60001
6 years, 1 month ago (2014-10-25 16:23:13 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-25 17:53:34 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 17:54:11 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/8eaec82caaae926faedbfd7df0beb4979c3f6792
Cr-Commit-Position: refs/heads/master@{#301286}

Powered by Google App Engine
This is Rietveld 408576698